[M] Change in coreboot[main]: intelvbtupgrader: Add a tool to upgrade VBT files to newer versions

[Angel Pons (Code Review)]

Attention is currently required from: Nicholas Chin, Paul Menzel, Vladimir Serbinenko.

Angel Pons has posted comments on this change by Vladimir Serbinenko. ( https://review.coreboot.org/c/coreboot/+/82722?usp=email )

Change subject: intelvbtupgrader: Add a tool to upgrade VBT files to newer versions
......................................................................

Patch Set 8:

(8 comments)

File util/README.md:

https://review.coreboot.org/c/coreboot/+/82722/comment/b41b6724_7eb03fda?usp... :
PS8, Line 67: * __intelvbtupgrader__ - Upgrade VBT to newer version
Specify the language this tool is written in:

```suggestion
* __intelvbtupgrader__ - Upgrade VBT to newer version `C`
```

File util/intelvbtupgrader/Makefile:

https://review.coreboot.org/c/coreboot/+/82722/comment/1e70f240_48bc4d7b?usp... :
PS8, Line 1: ##
nit: drop this line

File util/intelvbtupgrader/intelvbtupgrader.c:

https://review.coreboot.org/c/coreboot/+/82722/comment/7bfcbc41_94900560?usp... :
PS8, Line 92: VERSION
Is this the input version or the output version?

https://review.coreboot.org/c/coreboot/+/82722/comment/eb98dab5_85f9c63a?usp... :
PS8, Line 93: 		return 0;
Return non-zero from error paths to indicate failure?

https://review.coreboot.org/c/coreboot/+/82722/comment/a3642af0_1c2f3f31?usp... :
PS8, Line 108: 	fin = fopen(argv[1], "rb");
No error checking? I also see that not all paths close the files.

https://review.coreboot.org/c/coreboot/+/82722/comment/5597a3b8_0e756cf0?usp... :
PS8, Line 113: 		printf("Head version not 1.00\n");
Why is this a problem?

https://review.coreboot.org/c/coreboot/+/82722/comment/ef058bb4_00afc215?usp... :
PS8, Line 123: 		printf("invalid BDB offset\n");
Perhaps print the invalid value?

```suggestion
    	printf("invalid BDB offset %u\n", head.bdb_offset);
```

https://review.coreboot.org/c/coreboot/+/82722/comment/99d3da69_e91d8fa0?usp... :
PS8, Line 138: 		printf("Already at target or higher. Nothing to do\n");
Could this check be done earlier? I would avoid writing a partial output file if there's no need.