Hello Aamir Bohra,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/35079
to review the following change.
Change subject: Enable HDA for drallion platform ......................................................................
Enable HDA for drallion platform
Enable PchHdaDspEnable, PchHdaIDispCodecDisconnect and PchHdaAudioLinkHda for drallion variants. This is needed with FSP 1263.
Signed-off-by: Selma BENSAID selma.bensaid@intel.com Change-Id: I13d3dd832c6fbdc2aad5ba578695edb8470806e8 --- M src/mainboard/google/drallion/variants/arcada_cml/devicetree.cb M src/mainboard/google/drallion/variants/drallion/devicetree.cb M src/mainboard/google/drallion/variants/sarien_cml/devicetree.cb 3 files changed, 18 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/35079/1
diff --git a/src/mainboard/google/drallion/variants/arcada_cml/devicetree.cb b/src/mainboard/google/drallion/variants/arcada_cml/devicetree.cb index fe3b6c9..8470a2c 100644 --- a/src/mainboard/google/drallion/variants/arcada_cml/devicetree.cb +++ b/src/mainboard/google/drallion/variants/arcada_cml/devicetree.cb @@ -50,6 +50,12 @@ # Enable DDC for DDI port B register "DdiPortBDdc" = "1"
+ # HDA a + register "PchHdaDspEnable" = "1" + # Disable iDisplay codec enumeration + register "PchHdaIDispCodecDisconnect" = "1" + register "PchHdaAudioLinkHda" = "1" + # VR Settings Configuration for 4 Domains #+----------------+-------+-------+-------+-------+ #| Domain/Setting | SA | IA | GTUS | GTS | diff --git a/src/mainboard/google/drallion/variants/drallion/devicetree.cb b/src/mainboard/google/drallion/variants/drallion/devicetree.cb index 575b610..8e54625 100644 --- a/src/mainboard/google/drallion/variants/drallion/devicetree.cb +++ b/src/mainboard/google/drallion/variants/drallion/devicetree.cb @@ -50,6 +50,12 @@ # Enable DDC for DDI port B register "DdiPortBDdc" = "1"
+ # HDA a + register "PchHdaDspEnable" = "1" + # Disable iDisplay codec enumeration + register "PchHdaIDispCodecDisconnect" = "1" + register "PchHdaAudioLinkHda" = "1" + # VR Settings Configuration for 4 Domains #+----------------+-------+-------+-------+-------+ #| Domain/Setting | SA | IA | GTUS | GTS | diff --git a/src/mainboard/google/drallion/variants/sarien_cml/devicetree.cb b/src/mainboard/google/drallion/variants/sarien_cml/devicetree.cb index d3aab62..530d6f4 100644 --- a/src/mainboard/google/drallion/variants/sarien_cml/devicetree.cb +++ b/src/mainboard/google/drallion/variants/sarien_cml/devicetree.cb @@ -56,6 +56,12 @@ register "LanWakeFromDeepSx" = "0" register "WolEnableOverride" = "0"
+ # HDA a + register "PchHdaDspEnable" = "1" + # Disable iDisplay codec enumeration + register "PchHdaIDispCodecDisconnect" = "1" + register "PchHdaAudioLinkHda" = "1" + # VR Settings Configuration for 4 Domains #+----------------+-------+-------+-------+-------+ #| Domain/Setting | SA | IA | GTUS | GTS |
Hello Bernardo Perez Priego, Aamir Bohra, Mathew King, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35079
to look at the new patch set (#2).
Change subject: Enable HDA for drallion platform ......................................................................
Enable HDA for drallion platform
Enable PchHdaDspEnable, PchHdaIDispCodecDisconnect and PchHdaAudioLinkHda for drallion variants. This is needed with FSP 1263.
Signed-off-by: Selma BENSAID selma.bensaid@intel.com Change-Id: I13d3dd832c6fbdc2aad5ba578695edb8470806e8 --- M src/mainboard/google/drallion/variants/arcada_cml/devicetree.cb M src/mainboard/google/drallion/variants/drallion/devicetree.cb M src/mainboard/google/drallion/variants/sarien_cml/devicetree.cb 3 files changed, 18 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/35079/2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35079 )
Change subject: Enable HDA for drallion platform ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35079/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35079/2//COMMIT_MSG@7 PS2, Line 7: Enable HDA for drallion platform mb/google/drallion:
Hello Bernardo Perez Priego, Aamir Bohra, Mathew King, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35079
to look at the new patch set (#3).
Change subject: mb/google/drallion: Enable HDA for drallion platform ......................................................................
mb/google/drallion: Enable HDA for drallion platform
Enable PchHdaDspEnable, PchHdaIDispCodecDisconnect and PchHdaAudioLinkHda for drallion variants. This is needed with FSP 1263.
Signed-off-by: Selma BENSAID selma.bensaid@intel.com Change-Id: I13d3dd832c6fbdc2aad5ba578695edb8470806e8 --- M src/mainboard/google/drallion/variants/arcada_cml/devicetree.cb M src/mainboard/google/drallion/variants/drallion/devicetree.cb M src/mainboard/google/drallion/variants/sarien_cml/devicetree.cb 3 files changed, 18 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/35079/3
Sathyanarayana Nujella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35079 )
Change subject: mb/google/drallion: Enable HDA for drallion platform ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35079/3/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35079/3/src/mainboard/google/dralli... PS3, Line 54: PchHdaDspEnable Can you please cross check functionality without this UPD flag? DSP enablement may not be needed to use HDA controller directly.
Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35079 )
Change subject: mb/google/drallion: Enable HDA for drallion platform ......................................................................
Patch Set 3: Code-Review+2
Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35079 )
Change subject: mb/google/drallion: Enable HDA for drallion platform ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35079/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35079/2//COMMIT_MSG@7 PS2, Line 7: Enable HDA for drallion platform
mb/google/drallion:
Done
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35079 )
Change subject: mb/google/drallion: Enable HDA for drallion platform ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35079/3/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35079/3/src/mainboard/google/dralli... PS3, Line 54: PchHdaDspEnable
Can you please cross check functionality without this UPD flag? […]
Waiting for this comment to be addressed before merging.
Hello Bernardo Perez Priego, Aamir Bohra, Joyce Toh, Mathew King, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35079
to look at the new patch set (#4).
Change subject: mb/google/drallion: Enable HDA for drallion platform ......................................................................
mb/google/drallion: Enable HDA for drallion platform
Enable PchHdaIDispCodecDisconnect and PchHdaAudioLinkHda for drallion variants. This is needed with FSP 1263.
Signed-off-by: Selma BENSAID selma.bensaid@intel.com Change-Id: I13d3dd832c6fbdc2aad5ba578695edb8470806e8 --- M src/mainboard/google/drallion/variants/arcada_cml/devicetree.cb M src/mainboard/google/drallion/variants/drallion/devicetree.cb M src/mainboard/google/drallion/variants/sarien_cml/devicetree.cb 3 files changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/35079/4
Selma Bensaid has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35079 )
Change subject: mb/google/drallion: Enable HDA for drallion platform ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35079/3/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35079/3/src/mainboard/google/dralli... PS3, Line 54: PchHdaDspEnable
Waiting for this comment to be addressed before merging.
Done Test Audio OK without enabling PchHdaDspEnable
Sathyanarayana Nujella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35079 )
Change subject: mb/google/drallion: Enable HDA for drallion platform ......................................................................
Patch Set 4: Code-Review+1
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35079 )
Change subject: mb/google/drallion: Enable HDA for drallion platform ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/35079 )
Change subject: mb/google/drallion: Enable HDA for drallion platform ......................................................................
mb/google/drallion: Enable HDA for drallion platform
Enable PchHdaIDispCodecDisconnect and PchHdaAudioLinkHda for drallion variants. This is needed with FSP 1263.
Signed-off-by: Selma BENSAID selma.bensaid@intel.com Change-Id: I13d3dd832c6fbdc2aad5ba578695edb8470806e8 Reviewed-on: https://review.coreboot.org/c/coreboot/+/35079 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Sathyanarayana Nujella sathyanarayana.nujella@intel.com Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/drallion/variants/arcada_cml/devicetree.cb M src/mainboard/google/drallion/variants/drallion/devicetree.cb M src/mainboard/google/drallion/variants/sarien_cml/devicetree.cb 3 files changed, 12 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Sathyanarayana Nujella: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/drallion/variants/arcada_cml/devicetree.cb b/src/mainboard/google/drallion/variants/arcada_cml/devicetree.cb index fe3b6c9..3628264 100644 --- a/src/mainboard/google/drallion/variants/arcada_cml/devicetree.cb +++ b/src/mainboard/google/drallion/variants/arcada_cml/devicetree.cb @@ -50,6 +50,10 @@ # Enable DDC for DDI port B register "DdiPortBDdc" = "1"
+ # Disable iDisplay codec enumeration + register "PchHdaIDispCodecDisconnect" = "1" + register "PchHdaAudioLinkHda" = "1" + # VR Settings Configuration for 4 Domains #+----------------+-------+-------+-------+-------+ #| Domain/Setting | SA | IA | GTUS | GTS | diff --git a/src/mainboard/google/drallion/variants/drallion/devicetree.cb b/src/mainboard/google/drallion/variants/drallion/devicetree.cb index 54184f0..8870126 100644 --- a/src/mainboard/google/drallion/variants/drallion/devicetree.cb +++ b/src/mainboard/google/drallion/variants/drallion/devicetree.cb @@ -50,6 +50,10 @@ # Enable DDC for DDI port B register "DdiPortBDdc" = "1"
+ # Disable iDisplay codec enumeration + register "PchHdaIDispCodecDisconnect" = "1" + register "PchHdaAudioLinkHda" = "1" + # VR Settings Configuration for 4 Domains #+----------------+-------+-------+-------+-------+ #| Domain/Setting | SA | IA | GTUS | GTS | diff --git a/src/mainboard/google/drallion/variants/sarien_cml/devicetree.cb b/src/mainboard/google/drallion/variants/sarien_cml/devicetree.cb index d3aab62..84aacd5 100644 --- a/src/mainboard/google/drallion/variants/sarien_cml/devicetree.cb +++ b/src/mainboard/google/drallion/variants/sarien_cml/devicetree.cb @@ -56,6 +56,10 @@ register "LanWakeFromDeepSx" = "0" register "WolEnableOverride" = "0"
+ # Disable iDisplay codec enumeration + register "PchHdaIDispCodecDisconnect" = "1" + register "PchHdaAudioLinkHda" = "1" + # VR Settings Configuration for 4 Domains #+----------------+-------+-------+-------+-------+ #| Domain/Setting | SA | IA | GTUS | GTS |
-
Furquan Shaikh (Code Review) -
Martin Roth (Code Review)
-
Mathew King (Code Review)
-
Patrick Georgi (Code Review)
-
Sathyanarayana Nujella (Code Review)
-
Selma Bensaid (Code Review)