Hello Marshall Dawson, Marshall Dawson,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/40294
to review the following change.
Change subject: cpu/x86/smm.h: Add SW SMI for PSP SMM Info ......................................................................
cpu/x86/smm.h: Add SW SMI for PSP SMM Info
Add a definition for a software SMI to allow AMD systems supporting the MboxBiosCmdSmmInfo command to properly initialize the PSP.
Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Change-Id: I1d78aabb75cb76178a3606777d6a11f1e8806d9b --- M src/include/cpu/x86/smm.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/40294/1
diff --git a/src/include/cpu/x86/smm.h b/src/include/cpu/x86/smm.h index 0b76708..afa8cf4 100644 --- a/src/include/cpu/x86/smm.h +++ b/src/include/cpu/x86/smm.h @@ -25,6 +25,7 @@ #define APM_CNT_GNVS_UPDATE 0xea #define APM_CNT_FINALIZE 0xcb #define APM_CNT_LEGACY 0xcc +#define APM_CNT_SMMINFO 0xec #define APM_CNT_SMMSTORE 0xed #define APM_CNT_ELOG_GSMI 0xef #define APM_STS 0xb3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40294 )
Change subject: cpu/x86/smm.h: Add SW SMI for PSP SMM Info ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Marshall Dawson, Marshall Dawson, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40294
to look at the new patch set (#3).
Change subject: cpu/x86/smm.h: Add SW SMI for PSP SMM Info ......................................................................
cpu/x86/smm.h: Add SW SMI for PSP SMM Info
Add a definition for a software SMI to allow AMD systems supporting the MboxBiosCmdSmmInfo command to properly initialize the PSP.
BUG=b:153677737
Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Change-Id: I1d78aabb75cb76178a3606777d6a11f1e8806d9b --- M src/include/cpu/x86/smm.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/40294/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40294 )
Change subject: cpu/x86/smm.h: Add SW SMI for PSP SMM Info ......................................................................
Patch Set 4: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40294 )
Change subject: cpu/x86/smm.h: Add SW SMI for PSP SMM Info ......................................................................
cpu/x86/smm.h: Add SW SMI for PSP SMM Info
Add a definition for a software SMI to allow AMD systems supporting the MboxBiosCmdSmmInfo command to properly initialize the PSP.
BUG=b:153677737
Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Change-Id: I1d78aabb75cb76178a3606777d6a11f1e8806d9b Reviewed-on: https://review.coreboot.org/c/coreboot/+/40294 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/include/cpu/x86/smm.h 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/include/cpu/x86/smm.h b/src/include/cpu/x86/smm.h index 0b76708..afa8cf4 100644 --- a/src/include/cpu/x86/smm.h +++ b/src/include/cpu/x86/smm.h @@ -25,6 +25,7 @@ #define APM_CNT_GNVS_UPDATE 0xea #define APM_CNT_FINALIZE 0xcb #define APM_CNT_LEGACY 0xcc +#define APM_CNT_SMMINFO 0xec #define APM_CNT_SMMSTORE 0xed #define APM_CNT_ELOG_GSMI 0xef #define APM_STS 0xb3
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40294 )
Change subject: cpu/x86/smm.h: Add SW SMI for PSP SMM Info ......................................................................
Patch Set 5:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2287 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2286 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2285
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Felix Held (Code Review)