Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41290 )
Change subject: Documentation: Add GbE and test results disabling it ......................................................................
Documentation: Add GbE and test results disabling it
The GbE region should not be disabled without further IFD modifications.
Change-Id: Ie7e3104bcf9cf28b32f15ec4268d8a3fa35c0d9f Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- A Documentation/soc/intel/gbe.md M Documentation/soc/intel/index.md 2 files changed, 25 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/41290/1
diff --git a/Documentation/soc/intel/gbe.md b/Documentation/soc/intel/gbe.md new file mode 100644 index 0000000..19094c6 --- /dev/null +++ b/Documentation/soc/intel/gbe.md @@ -0,0 +1,21 @@ +# Intel Flash descriptor GbE region + +The gigabit ethernet (GbE) region is an 8 KiB reserved area of the x86 boot +NOR SPI flash. The position withing the flash is specified by the IFD. + +The GbE regiong stores configuration data, for e.g. the MAC address +of the Intel onboard network interface card. Thus if the Intel onboard +network card isn't used by the mainboard, there's no GbE region present. + +The GbE region is named `gbe` in flashrom and ifdtool. + +# Removing the GbE + +Removing the GbE (marking the region as unused in the IFD) on a platform +that has the onboard NIC enabled in fuses results in a no boot. + +# Clearing the GbE region + +Overwriting the GbE region allows to boot and the GbE PCI device shows +up on GNU/Linux. The e1000e fails to load with 'error -3'. + diff --git a/Documentation/soc/intel/index.md b/Documentation/soc/intel/index.md index f30ff9a..2df1fe6 100644 --- a/Documentation/soc/intel/index.md +++ b/Documentation/soc/intel/index.md @@ -10,3 +10,7 @@ - [MP Initialization](mp_init/mp_init.md) - [Firmware Interface Table](fit.md) - [Apollolake](apollolake/index.md) + +## IFD + +- [GbE region](gbe.md)
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41290 )
Change subject: Documentation: Add GbE and test results disabling it ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/c/coreboot/+/41290/1/Documentation/soc/intel/gbe... File Documentation/soc/intel/gbe.md:
https://review.coreboot.org/c/coreboot/+/41290/1/Documentation/soc/intel/gbe... PS1, Line 4: withing within
https://review.coreboot.org/c/coreboot/+/41290/1/Documentation/soc/intel/gbe... PS1, Line 6: regiong region
https://review.coreboot.org/c/coreboot/+/41290/1/Documentation/soc/intel/gbe... PS1, Line 15: in a no boot In the OS, the firmware?
https://review.coreboot.org/c/coreboot/+/41290/1/Documentation/soc/intel/gbe... PS1, Line 19: Overwriting How?
https://review.coreboot.org/c/coreboot/+/41290/1/Documentation/soc/intel/gbe... PS1, Line 20: up on GNU/Linux. The e1000e fails to load with 'error -3'. On the Lenovo X230, for example:
e1000e: probe of 0000:00:19:0 failed with error -3
https://review.coreboot.org/c/coreboot/+/41290/1/Documentation/soc/intel/gbe... PS1, Line 22: Remove one blank line.
Christian Walter has uploaded a new patch set (#2) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/41290 )
Change subject: Documentation: Add GbE and test results disabling it ......................................................................
Documentation: Add GbE and test results disabling it
The GbE region should not be disabled without further IFD modifications.
Change-Id: Ie7e3104bcf9cf28b32f15ec4268d8a3fa35c0d9f Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Signed-off-by: Christian Walter christian.walter@9elements.com --- A Documentation/soc/intel/gbe.md M Documentation/soc/intel/index.md 2 files changed, 26 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/41290/2
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41290 )
Change subject: Documentation: Add GbE and test results disabling it ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/41290/1/Documentation/soc/intel/gbe... File Documentation/soc/intel/gbe.md:
https://review.coreboot.org/c/coreboot/+/41290/1/Documentation/soc/intel/gbe... PS1, Line 4: withing
within
Done
https://review.coreboot.org/c/coreboot/+/41290/1/Documentation/soc/intel/gbe... PS1, Line 6: regiong
region
Done
https://review.coreboot.org/c/coreboot/+/41290/1/Documentation/soc/intel/gbe... PS1, Line 20: up on GNU/Linux. The e1000e fails to load with 'error -3'.
On the Lenovo X230, for example: […]
Done
https://review.coreboot.org/c/coreboot/+/41290/1/Documentation/soc/intel/gbe... PS1, Line 22:
Remove one blank line.
Done
Christian Walter has uploaded a new patch set (#3) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/41290 )
Change subject: Documentation: Add GbE and test results disabling it ......................................................................
Documentation: Add GbE and test results disabling it
The GbE region should not be disabled without further IFD modifications.
Change-Id: Ie7e3104bcf9cf28b32f15ec4268d8a3fa35c0d9f Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Signed-off-by: Christian Walter christian.walter@9elements.com --- A Documentation/soc/intel/gbe.md M Documentation/soc/intel/index.md 2 files changed, 26 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/41290/3
Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41290?usp=email )
Change subject: Documentation: Add GbE and test results disabling it ......................................................................
Abandoned
-
Christian Walter (Code Review) -
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)
-
Stefan Reinauer (Code Review)