Yidi Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86302?usp=email )
Change subject: soc/mediatek/mt8196: Correct assert conditions ......................................................................
soc/mediatek/mt8196: Correct assert conditions
Correct the assert conditions in dptx_hal_setswing_preemphasis() and dptx_hal_phy_set_swing_preemphasis().
BRANCH=rauru BUG=b:376357839 TEST=Verify FW screen with a 4 lanes panel on Hylia
Change-Id: I8830b05c976ea2ba987de6333b93e2394d3403ba Signed-off-by: Yidi Lin yidilin@chromium.org --- M src/soc/mediatek/mt8196/dptx_hal.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/86302/1
diff --git a/src/soc/mediatek/mt8196/dptx_hal.c b/src/soc/mediatek/mt8196/dptx_hal.c index 168d62b..e6078ae 100644 --- a/src/soc/mediatek/mt8196/dptx_hal.c +++ b/src/soc/mediatek/mt8196/dptx_hal.c @@ -87,7 +87,7 @@ bool dptx_hal_setswing_preemphasis(struct mtk_dp *mtk_dp, int lane_num, u8 swing_value, u8 preemphasis) { - assert(lane_num < DPTX_LANE_MAX); + assert(lane_num <= DPTX_LANE_MAX);
for (int i = 0; i < lane_num; ++i) { mtk_dp_phy_mask(mtk_dp, driving_offset[i], @@ -348,7 +348,7 @@ void dptx_hal_phy_set_swing_preemphasis(struct mtk_dp *mtk_dp, u8 lane_count, u8 *swing_val, u8 *preemphasis) { - assert(lane_count < DPTX_LANE_MAX); + assert(lane_count <= DPTX_LANE_MAX);
for (int i = 0; i < lane_count; ++i) { mtk_dp_phy_mask(mtk_dp, driving_offset[i],