Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30118 )
Change subject: arch/x86/boot: Jump to payload in protected mode ......................................................................
Patch Set 32:
(2 comments)
Fixed comments and used exit32.inc instead, which reduces duplicated code a lot.
https://review.coreboot.org/c/coreboot/+/30118/32/Documentation/arch/x86/ind... File Documentation/arch/x86/index.md:
https://review.coreboot.org/c/coreboot/+/30118/32/Documentation/arch/x86/ind... PS32, Line 18: run
called/'jumped to' is more accurate?
Done
https://review.coreboot.org/c/coreboot/+/30118/32/src/include/program_loadin... File src/include/program_loading.h:
https://review.coreboot.org/c/coreboot/+/30118/32/src/include/program_loadin... PS32, Line 177: /* : * Jump to function in protected mode. : * @arg func_ptr Function to jump to in protected mode : * @arg Argument to pass to called function : * : * @noreturn : */ : void protected_mode_jump(uint32_t func_ptr, : uint32_t argument);
I'm not sure if this generic program loading file is supposed to hold x86 specific function declarat […]
Done
-
Patrick Rudolph (Code Review)