Attention is currently required from: Tarun Tuli, Eran Mitrani, Subrata Banik.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70166 )
Change subject: soc/intel/{adl,common}: provide a list of D-states to enter LPM ......................................................................
Patch Set 9:
(3 comments)
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/70166/comment/ca62edc2_7f6bd562 PS9, Line 458: states_arr This check can be moved to the place where the variable `states_arr` is being used i.e. after line number 467.
https://review.coreboot.org/c/coreboot/+/70166/comment/c50f413e_87dcd0eb PS9, Line 467: NONE `ACPI_DEVICE_SLEEP_NONE`?
https://review.coreboot.org/c/coreboot/+/70166/comment/34d44b4b_41fdfedf PS9, Line 494: return it is not required anymore.