Change in coreboot[master]: mb/google/drallion: Disable GBE in firmware for drallion variants
Hello Thejaswani Putta,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/35509
to review the following change.
Change subject: mb/google/drallion: Disable GBE in firmware for drallion variants ......................................................................
mb/google/drallion: Disable GBE in firmware for drallion variants
BUG: None TEST: Build and boot, check if 1f.6 is off on drallion variants
Signed-off-by: Thejaswani Putta thejaswani.putta@intel.corp-partner.google.com Change-Id: I4e74b259ce8f5f70833dce94692dcbe33e8504db --- M src/mainboard/google/drallion/variants/sarien_cml/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/35509/1
diff --git a/src/mainboard/google/drallion/variants/sarien_cml/devicetree.cb b/src/mainboard/google/drallion/variants/sarien_cml/devicetree.cb index f2367ff..8cb1aa3 100644 --- a/src/mainboard/google/drallion/variants/sarien_cml/devicetree.cb +++ b/src/mainboard/google/drallion/variants/sarien_cml/devicetree.cb @@ -417,6 +417,6 @@ device pci 1f.3 on end # Intel HDA device pci 1f.4 on end # SMBus device pci 1f.5 on end # PCH SPI - device pci 1f.6 on end # GbE + device pci 1f.6 off end # GbE end end
Hello build bot (Jenkins), Thejaswani Putta,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35509
to look at the new patch set (#2).
Change subject: mb/google/drallion: Disable GBE in firmware for drallion variants ......................................................................
mb/google/drallion: Disable GBE in firmware for drallion variants
BUG: None
Signed-off-by: Thejaswani Putta thejaswani.putta@intel.corp-partner.google.com Change-Id: I4e74b259ce8f5f70833dce94692dcbe33e8504db --- M src/mainboard/google/drallion/variants/sarien_cml/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/35509/2
Hello AndreX Andraos, Varun Joshi, Bernardo Perez Priego, Selma Bensaid, Bora Guvendik, build bot (Jenkins), Chiranjeevi Rapolu, Thejaswani Putta,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35509
to look at the new patch set (#3).
Change subject: mb/google/drallion: Disable GBE in firmware for drallion variants ......................................................................
mb/google/drallion: Disable GBE in firmware for drallion variants
BUG: None TEST: Build successful, checked the Cbmem log if 1f.6 is disabled with this patch
Signed-off-by: Thejaswani Putta thejaswani.putta@intel.corp-partner.google.com Change-Id: I4e74b259ce8f5f70833dce94692dcbe33e8504db --- M src/mainboard/google/drallion/variants/sarien_cml/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/35509/3
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35509 )
Change subject: mb/google/drallion: Disable GBE in firmware for drallion variants ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35509/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35509/3//COMMIT_MSG@8 PS3, Line 8: Why? Is there no interface?
https://review.coreboot.org/c/coreboot/+/35509/3//COMMIT_MSG@10 PS3, Line 10: Cbmem CBMEM
Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35509 )
Change subject: mb/google/drallion: Disable GBE in firmware for drallion variants ......................................................................
Patch Set 3:
Shouldn't this be on the drallion variant not sarien_cml?
Thejaswani Putta has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35509 )
Change subject: mb/google/drallion: Disable GBE in firmware for drallion variants ......................................................................
Patch Set 3:
(2 comments)
Patch Set 3:
Shouldn't this be on the drallion variant not sarien_cml?
1f.6 is already disabled in arcada_cml and drallion variant. Sarien_cml is the only variant where it is still ON. so disabling the same.
https://review.coreboot.org/c/coreboot/+/35509/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35509/3//COMMIT_MSG@8 PS3, Line 8:
Why? Is there no interface?
No, this is not a POR for drallion.
https://review.coreboot.org/c/coreboot/+/35509/3//COMMIT_MSG@10 PS3, Line 10: Cbmem
CBMEM
Done
Thejaswani Putta has uploaded a new patch set (#4) to the change originally created by Thejaswani Putta. ( https://review.coreboot.org/c/coreboot/+/35509 )
Change subject: mb/google/drallion: Disable GBE in firmware for drallion variants ......................................................................
mb/google/drallion: Disable GBE in firmware for drallion variants
BUG: None TEST: Build successful, checked the CBMEM log if 1f.6 is disabled with this patch
Signed-off-by: Thejaswani Putta thejaswani.putta@intel.corp-partner.google.com Change-Id: I4e74b259ce8f5f70833dce94692dcbe33e8504db --- M src/mainboard/google/drallion/variants/sarien_cml/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/35509/4
Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35509 )
Change subject: mb/google/drallion: Disable GBE in firmware for drallion variants ......................................................................
Patch Set 4: Code-Review+2
Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35509 )
Change subject: mb/google/drallion: Disable GBE in firmware for drallion variants ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35509 )
Change subject: mb/google/drallion: Disable GBE in firmware for drallion variants ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35509/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35509/3//COMMIT_MSG@8 PS3, Line 8:
No, this is not a POR for drallion.
done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35509 )
Change subject: mb/google/drallion: Disable GBE in firmware for drallion variants ......................................................................
mb/google/drallion: Disable GBE in firmware for drallion variants
BUG: None TEST: Build successful, checked the CBMEM log if 1f.6 is disabled with this patch
Signed-off-by: Thejaswani Putta thejaswani.putta@intel.corp-partner.google.com Change-Id: I4e74b259ce8f5f70833dce94692dcbe33e8504db Reviewed-on: https://review.coreboot.org/c/coreboot/+/35509 Reviewed-by: Mathew King mathewk@chromium.org Reviewed-by: Bora Guvendik bora.guvendik@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/drallion/variants/sarien_cml/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Bora Guvendik: Looks good to me, approved Mathew King: Looks good to me, approved
diff --git a/src/mainboard/google/drallion/variants/sarien_cml/devicetree.cb b/src/mainboard/google/drallion/variants/sarien_cml/devicetree.cb index f2367ff..8cb1aa3 100644 --- a/src/mainboard/google/drallion/variants/sarien_cml/devicetree.cb +++ b/src/mainboard/google/drallion/variants/sarien_cml/devicetree.cb @@ -417,6 +417,6 @@ device pci 1f.3 on end # Intel HDA device pci 1f.4 on end # SMBus device pci 1f.5 on end # PCH SPI - device pci 1f.6 on end # GbE + device pci 1f.6 off end # GbE end end
-
Bora Guvendik (Code Review) -
Mathew King (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Thejaswani Putta (Code Review)