Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28101 )
Change subject: Makefile: Add $(xcompile) to specify where to write xcompile
......................................................................
Patch Set 11: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/28101/11/Makefile
File Makefile:
https://review.coreboot.org/c/coreboot/+/28101/11/Makefile@154
PS11, Line 154: util/xcompile/xcompile $(XGCCPATH) > $(xcompile) || rm -f $(xcompile)))
Should we redirect stderr to /dev/null just in case? The `include` below
should give a reasonable error message if something goes wrong but any
output of the `$(shell )` call would likely result in a mess.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/28101
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia83f234447b977efa824751c9674154b77d606b0
Gerrit-Change-Number: 28101
Gerrit-PatchSet: 11
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Raul Rangel
rrangel@google.com
Gerrit-Comment-Date: Tue, 08 Dec 2020 23:49:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment