Attention is currently required from: Bora Guvendik, Selma Bensaid, Julius Werner, Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59507 )
Change subject: soc/intel/alderlake: Inject CSE TS into timestamp_table ......................................................................
Patch Set 12:
(12 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59507/comment/0db7cbd2_73b5dbb6 PS12, Line 7: timestamp_table CBMEM timestamp table
https://review.coreboot.org/c/coreboot/+/59507/comment/7a68ada0_fca1dc35 PS12, Line 9: it them
https://review.coreboot.org/c/coreboot/+/59507/comment/11339588_f5cdf2e0 PS12, Line 11: Please mention, that they need to be normalized?
https://review.coreboot.org/c/coreboot/+/59507/comment/ab605df0_3d6bd15e PS12, Line 13: TEST=Able to see TS elapse prior to IA reset. Please mention the board, and even paste the new output.
File src/soc/intel/common/block/cse/telemetry.c:
https://review.coreboot.org/c/coreboot/+/59507/comment/6c963768_c6672bef PS12, Line 33: int `unsigned int` or `size_t`
https://review.coreboot.org/c/coreboot/+/59507/comment/ea8fae9d_dac0a47d PS12, Line 35: 0xFFFFFFFF Please use lowercase.
https://review.coreboot.org/c/coreboot/+/59507/comment/c444d7c3_73b85fb7 PS12, Line 36: printk(BIOS_ERR, "%s: CSME timestamps invalid\n", __func__); What should the user do in such a case?
https://review.coreboot.org/c/coreboot/+/59507/comment/0418ac25_e3b902ce PS12, Line 45: int Ditto.
https://review.coreboot.org/c/coreboot/+/59507/comment/097f4b65_c53b4598 PS12, Line 53: int Ditto.
https://review.coreboot.org/c/coreboot/+/59507/comment/6e22fd19_2e3137a2 PS12, Line 53: zero_point_idx+1 Please add spaces around operators.
https://review.coreboot.org/c/coreboot/+/59507/comment/d09e20d9_e4a0cf77 PS12, Line 56: printk(BIOS_ERR, "%s: CSME timestamps invalid\n", __func__); 1. Print the value both values? 2. What should the user do?
File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/59507/comment/e4515120_5dad1c51 PS12, Line 502: coreboot CBMEM