Change in coreboot[master]: mb/ocp/deltalake: add RW_MRC_CACHE flash region

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Jonathan Zhang (Code Review)

3 Jun 2020 3 Jun '20

2:54 a.m.

Jonathan Zhang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42025 )

Change subject: mb/ocp/deltalake: add RW_MRC_CACHE flash region ......................................................................

mb/ocp/deltalake: add RW_MRC_CACHE flash region

Add RW_MRC_CACHE flash region to hold MRC cache data.

Signed-off-by: Jonathan Zhang jonzhang@fb.com Change-Id: I27ed00100e1ea9e29b0e71ea5a8397cd550e193a --- M src/mainboard/ocp/deltalake/board.fmd 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/42025/1

diff --git a/src/mainboard/ocp/deltalake/board.fmd b/src/mainboard/ocp/deltalake/board.fmd index 24c7f33..5b8c430 100644 --- a/src/mainboard/ocp/deltalake/board.fmd +++ b/src/mainboard/ocp/deltalake/board.fmd @@ -6,6 +6,7 @@ } SI_BIOS@0x3000000 0x1000000 { FMAP@0x0 0x800 - COREBOOT(CBFS)@0x800 0xfff800 + RW_MRC_CACHE@0x800 0x10000 + COREBOOT(CBFS)@0x10800 0xfef800 } }

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

Patrick Rudolph (Code Review)

9 Jun 9 Jun

7:42 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42025 )

Change subject: mb/ocp/deltalake: add RW_MRC_CACHE flash region ......................................................................

Patch Set 4: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/42025/4/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/board.fmd:

https://review.coreboot.org/c/coreboot/+/42025/4/src/mainboard/ocp/deltalake... PS4, Line 9: RW_MRC_CACHE@0x800 0x10000 mrc cache needs to be aligned to 4K for SPI protected regions to work properly

https://review.coreboot.org/c/coreboot/+/42025/4/src/mainboard/ocp/deltalake... PS4, Line 10: COREBOOT(CBFS)@0x10800 0xfef800 if you remove the size field of COREBOOT(CBFS) it will fill up the remainig space

-- To view, visit https://review.coreboot.org/c/coreboot/+/42025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27ed00100e1ea9e29b0e71ea5a8397cd550e193a Gerrit-Change-Number: 42025 Gerrit-PatchSet: 4 Gerrit-Owner: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 09 Jun 2020 05:42:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

9:10 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42025 )

Change subject: mb/ocp/deltalake: add RW_MRC_CACHE flash region ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42025/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/42025/4//COMMIT_MSG@10 PS4, Line 10: Please add, if it works, and the cache data is used, and how much the boot time decreased.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27ed00100e1ea9e29b0e71ea5a8397cd550e193a Gerrit-Change-Number: 42025 Gerrit-PatchSet: 4 Gerrit-Owner: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 09 Jun 2020 07:10:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jonathan Zhang (Code Review)

9:34 p.m.

Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42025 )

Change subject: mb/ocp/deltalake: add RW_MRC_CACHE flash region ......................................................................

Patch Set 4:

(3 comments)

https://review.coreboot.org/c/coreboot/+/42025/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/42025/4//COMMIT_MSG@10 PS4, Line 10:

...

Please add, if it works, and the cache data is used, and how much the boot time decreased.

Sure, will do.

https://review.coreboot.org/c/coreboot/+/42025/4/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/board.fmd:

https://review.coreboot.org/c/coreboot/+/42025/4/src/mainboard/ocp/deltalake... PS4, Line 9: RW_MRC_CACHE@0x800 0x10000

...

mrc cache needs to be aligned to 4K for SPI protected regions to work properly

Done

https://review.coreboot.org/c/coreboot/+/42025/4/src/mainboard/ocp/deltalake... PS4, Line 10: COREBOOT(CBFS)@0x10800 0xfef800

...

if you remove the size field of COREBOOT(CBFS) it will fill up the remainig space

Thanks for the tip!

-- To view, visit https://review.coreboot.org/c/coreboot/+/42025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27ed00100e1ea9e29b0e71ea5a8397cd550e193a Gerrit-Change-Number: 42025 Gerrit-PatchSet: 4 Gerrit-Owner: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 09 Jun 2020 19:34:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org Gerrit-MessageType: comment

Jonathan Zhang (Code Review)

11:04 p.m.

Hello build bot (Jenkins), Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42025

to look at the new patch set (#5).

Change subject: mb/ocp/deltalake: add RW_MRC_CACHE flash region ......................................................................

mb/ocp/deltalake: add RW_MRC_CACHE flash region

Add RW_MRC_CACHE flash region to hold MRC cache data.

With memory training skipped for subsequent reboots, the boot time is reduced by 8 minutes on OCP Delta Lake server, when FSP verbose logging is turned on.

Signed-off-by: Jonathan Zhang jonzhang@fb.com Change-Id: I27ed00100e1ea9e29b0e71ea5a8397cd550e193a --- M src/mainboard/ocp/deltalake/board.fmd 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/42025/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/42025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27ed00100e1ea9e29b0e71ea5a8397cd550e193a Gerrit-Change-Number: 42025 Gerrit-PatchSet: 5 Gerrit-Owner: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Philipp Deppenwiese (Code Review)

18 Jun 18 Jun

1:33 a.m.

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42025 )

Change subject: mb/ocp/deltalake: add RW_MRC_CACHE flash region ......................................................................

Patch Set 12: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27ed00100e1ea9e29b0e71ea5a8397cd550e193a Gerrit-Change-Number: 42025 Gerrit-PatchSet: 12 Gerrit-Owner: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 17 Jun 2020 23:33:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

22 Jun 22 Jun

2:21 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42025 )

Change subject: mb/ocp/deltalake: add RW_MRC_CACHE flash region ......................................................................

mb/ocp/deltalake: add RW_MRC_CACHE flash region

Add RW_MRC_CACHE flash region to hold MRC cache data.

With memory training skipped for subsequent reboots, the boot time is reduced by 8 minutes on OCP Delta Lake server, when FSP verbose logging is turned on.

Signed-off-by: Jonathan Zhang jonzhang@fb.com Change-Id: I27ed00100e1ea9e29b0e71ea5a8397cd550e193a Reviewed-on: https://review.coreboot.org/c/coreboot/+/42025 Reviewed-by: Philipp Deppenwiese zaolin.daisuki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/ocp/deltalake/board.fmd 1 file changed, 2 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Philipp Deppenwiese: Looks good to me, approved

diff --git a/src/mainboard/ocp/deltalake/board.fmd b/src/mainboard/ocp/deltalake/board.fmd index 24c7f33..a0c8dc5 100644 --- a/src/mainboard/ocp/deltalake/board.fmd +++ b/src/mainboard/ocp/deltalake/board.fmd @@ -6,6 +6,7 @@ } SI_BIOS@0x3000000 0x1000000 { FMAP@0x0 0x800 - COREBOOT(CBFS)@0x800 0xfff800 + RW_MRC_CACHE@0x1000 0x10000 + COREBOOT(CBFS)@0x11000 } }

-- To view, visit https://review.coreboot.org/c/coreboot/+/42025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27ed00100e1ea9e29b0e71ea5a8397cd550e193a Gerrit-Change-Number: 42025 Gerrit-PatchSet: 13 Gerrit-Owner: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1564

days inactive

1583

days old

coreboot-gerrit@coreboot.org

6 comments

5 participants

tags (0)

participants (5)

Jonathan Zhang (Code Review)
Patrick Georgi (Code Review)
Patrick Rudolph (Code Review)
Paul Menzel (Code Review)
Philipp Deppenwiese (Code Review)