Attention is currently required from: Furquan Shaikh, Nick Vaccaro, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57125 )
Change subject: soc/intel/tgl: Enable USB4 resources based on common Kconfig
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57125/comment/e4ae0ac7_ebdf952b
PS5, Line 20: CB:51460
As this is merged, use the commit hash?
commit 8d11cdc6fa
(the `commit` part is important because it makes Gerrit display a link)
File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/57125/comment/b2bfe51c_f3505350
PS5, Line 296: int
It shouldn't be necessary to repeat the types here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57125
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25ec3f74ebd5727fa4b13f5a3b11050f77ecb008
Gerrit-Change-Number: 57125
Gerrit-PatchSet: 5
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 05 Sep 2021 14:06:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment