Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40467 )
Change subject: soc/intel/cannonlake: Report driver strength by _DSM in eMMC ACPI device
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40467/8/src/soc/intel/cannonlake/ac...
File src/soc/intel/cannonlake/acpi/scs.asl:
https://review.coreboot.org/c/coreboot/+/40467/8/src/soc/intel/cannonlake/ac...
PS8, Line 82: * Function Index 0 the return value is a buffer containing
Let's fix up these long lines and then it LGTM (max line length 96 characters).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40467
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1b4df8b0d1d2cad3a7f521ad47ee5a4b3320c767
Gerrit-Change-Number: 40467
Gerrit-PatchSet: 8
Gerrit-Owner: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 25 Apr 2020 19:25:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment