Maulik V Vaghela has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39585 )
Change subject: mb/intel/jasperlake_rvp: Add config check for lid switch ......................................................................
mb/intel/jasperlake_rvp: Add config check for lid switch
We should only define function to get lid switch and recovery mode switches when CHROMEEC_SWITCHES is not available. Correct this to avoid compilation issues
BUG=None BRANCH=None TEST=jslrvp code compilation is fine
Change-Id: I2445d40da1540c9d8c8c5fc845a4f38a5abf983e Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/intel/jasperlake_rvp/chromeos.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/39585/1
diff --git a/src/mainboard/intel/jasperlake_rvp/chromeos.c b/src/mainboard/intel/jasperlake_rvp/chromeos.c index 930f748..0991f29 100644 --- a/src/mainboard/intel/jasperlake_rvp/chromeos.c +++ b/src/mainboard/intel/jasperlake_rvp/chromeos.c @@ -29,6 +29,7 @@ lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios)); }
+#if !CONFIG(EC_GOOGLE_CHROMEEC_SWITCHES) int get_lid_switch(void) { /* Lid always open */ @@ -40,6 +41,8 @@ return 0; }
+#endif + int get_write_protect_state(void) { /* No write protect */
Hello build bot (Jenkins), Patrick Georgi, Rizwan Qureshi, Balaji Manigandan, Subrata Banik, Ronak Kanabar, Aamir Bohra,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39585
to look at the new patch set (#4).
Change subject: mb/intel/jasperlake_rvp: Add config check for lid switch ......................................................................
mb/intel/jasperlake_rvp: Add config check for lid switch
We should only define function to get lid switch and recovery mode switches when CHROMEEC_SWITCHES is not available. Correct this to avoid compilation issues
BUG=None BRANCH=None TEST=jslrvp code compilation is fine
Change-Id: I2445d40da1540c9d8c8c5fc845a4f38a5abf983e Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/intel/jasperlake_rvp/chromeos.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/39585/4
Hello build bot (Jenkins), Patrick Georgi, Rizwan Qureshi, Balaji Manigandan, Subrata Banik, Ronak Kanabar, Aamir Bohra,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39585
to look at the new patch set (#8).
Change subject: mb/intel/jasperlake_rvp: Add config check for lid switch ......................................................................
mb/intel/jasperlake_rvp: Add config check for lid switch
We should only define function to get lid switch and recovery mode switches when CHROMEEC_SWITCHES is not available. Correct this to avoid compilation issues
BUG=None BRANCH=None TEST=jslrvp code compilation is fine
Change-Id: I2445d40da1540c9d8c8c5fc845a4f38a5abf983e Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/intel/jasperlake_rvp/chromeos.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/39585/8
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39585 )
Change subject: mb/intel/jasperlake_rvp: Add config check for lid switch ......................................................................
Patch Set 9: Code-Review+2
Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39585 )
Change subject: mb/intel/jasperlake_rvp: Add config check for lid switch ......................................................................
Patch Set 11: Code-Review+2
V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39585 )
Change subject: mb/intel/jasperlake_rvp: Add config check for lid switch ......................................................................
Patch Set 11: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39585 )
Change subject: mb/intel/jasperlake_rvp: Add config check for lid switch ......................................................................
mb/intel/jasperlake_rvp: Add config check for lid switch
We should only define function to get lid switch and recovery mode switches when CHROMEEC_SWITCHES is not available. Correct this to avoid compilation issues
BUG=None BRANCH=None TEST=jslrvp code compilation is fine
Change-Id: I2445d40da1540c9d8c8c5fc845a4f38a5abf983e Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39585 Reviewed-by: Ronak Kanabar ronak.kanabar@intel.com Reviewed-by: V Sowmya v.sowmya@intel.com Reviewed-by: Aamir Bohra aamir.bohra@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/intel/jasperlake_rvp/chromeos.c 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Aamir Bohra: Looks good to me, approved V Sowmya: Looks good to me, approved Ronak Kanabar: Looks good to me, approved
diff --git a/src/mainboard/intel/jasperlake_rvp/chromeos.c b/src/mainboard/intel/jasperlake_rvp/chromeos.c index 2f2abb5..bee7eba 100644 --- a/src/mainboard/intel/jasperlake_rvp/chromeos.c +++ b/src/mainboard/intel/jasperlake_rvp/chromeos.c @@ -28,6 +28,7 @@ lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios)); }
+#if !CONFIG(EC_GOOGLE_CHROMEEC_SWITCHES) int get_lid_switch(void) { /* Lid always open */ @@ -39,6 +40,8 @@ return 0; }
+#endif /*!CONFIG(EC_GOOGLE_CHROMEEC_SWITCHES) */ + int get_write_protect_state(void) { /* No write protect */
-
Aamir Bohra (Code Review) -
Maulik V Vaghela (Code Review)
-
Patrick Georgi (Code Review)
-
Ronak Kanabar (Code Review)
-
V Sowmya (Code Review)