Attention is currently required from: Furquan Shaikh, Nick Vaccaro, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55828 )
Change subject: soc/intel/common/uart: Move fixed LPSS_UART IRQ selection to a new file ......................................................................
Patch Set 2:
(2 comments)
File src/soc/intel/common/block/uart/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/55828/comment/eaa7610b_1b3bbc94 PS2, Line 9: legacy
By legacy, I guess you mean the legacy behavior of assigning IRQs in FSP and using macros to determi […]
fair point, i'll find a better name
File src/soc/intel/common/block/uart/uart.c:
https://review.coreboot.org/c/coreboot/+/55828/comment/d800a8b1_1fd26872 PS2, Line 212: uart_get_fixed_irq(dev)
Currently, this gets used only for one board (hermes) which is cannonlake. […]
Good eye! Then it may be worth it; probably would only take a few days to get it working for cannonlake ... let me look at that.