Change in coreboot[master]: [WIP] ACPI: Allocate GNVS early in ramstage

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42463 )

Change subject: [WIP] ACPI: Allocate GNVS early in ramstage
......................................................................

[WIP] ACPI: Allocate GNVS early in ramstage

We need this to happen prior to SMM module loader. If
there is some debugging output it's better they do not
appear in the middle of CPU bringup.

Change-Id: I45b4b5c0c5bf8bee258a465d1e364bfe98190e44
Signed-off-by: Kyösti Mälkki 
---
M src/lib/hardwaremain.c
1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/42463/1

diff --git a/src/lib/hardwaremain.c b/src/lib/hardwaremain.c
index 59da967..6849ade 100644
--- a/src/lib/hardwaremain.c
+++ b/src/lib/hardwaremain.c
@@ -6,6 +6,7 @@
  */

#include <adainit.h>
+#include <acpi/acpi_gnvs.h>
 #include <arch/exception.h>
 #include <bootstate.h>
 #include <console/console.h>
@@ -450,6 +451,10 @@
 #endif
    threads_initialize();

+	/* Initialise GNVS early.
+	   FIXME: Platform gnvs_size_of_array() and friends not there yet. */
+	if (0) gnvs_get_or_create();
+
    /* Schedule the static boot state entries. */
    boot_state_schedule_static_entries();

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42463 )

Change subject: [WIP] ACPI: Allocate GNVS early in ramstage
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42463/1/src/lib/hardwaremain.c 
File src/lib/hardwaremain.c:

https://review.coreboot.org/c/coreboot/+/42463/1/src/lib/hardwaremain.c@456 
PS1, Line 456: 	if (0) gnvs_get_or_create();
trailing statements should be on next line

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42463 )

Change subject: [WIP] ACPI: Allocate GNVS early in ramstage
......................................................................

Patch Set 1:

Will need to coordinate w/ initialization of the struct, but overall it seems like it should work.

[Kyösti Mälkki (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42463

to look at the new patch set (#2).

Change subject: [WIP] ACPI: Allocate GNVS early in ramstage
......................................................................

[WIP] ACPI: Allocate GNVS early in ramstage

We need this to happen prior to SMM module loader. If
there is some debugging output it's better they do not
appear in the middle of CPU bringup.

Change-Id: I45b4b5c0c5bf8bee258a465d1e364bfe98190e44
Signed-off-by: Kyösti Mälkki 
---
M src/acpi/gnvs.c
M src/lib/hardwaremain.c
2 files changed, 7 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/42463/2

[Kyösti Mälkki (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42463

to look at the new patch set (#3).

Change subject: [WIP] ACPI: Allocate GNVS early in ramstage
......................................................................

[WIP] ACPI: Allocate GNVS early in ramstage

We need this to happen prior to SMM module loader. If
there is some debugging output it's better they do not
appear in the middle of CPU bringup.

Change-Id: I45b4b5c0c5bf8bee258a465d1e364bfe98190e44
Signed-off-by: Kyösti Mälkki 
---
M src/acpi/gnvs.c
M src/lib/hardwaremain.c
2 files changed, 8 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/42463/3

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42463 )

Change subject: [WIP] ACPI: Allocate GNVS early in ramstage
......................................................................

Patch Set 3:

How do you want to approach with the implementations for

size_t gnvs_size_of_array(void);
  uint32_t *gnvs_cbmc_ptr(void);
  void *gnvs_chromeos_ptr(void);

We could mostly do with one common implementation with <soc/nvs.h>.
Then have a KConfig to opt-out for individual <sb/intel/xxx/nvs.h> cases.

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42463 )

Change subject: [WIP] ACPI: Allocate GNVS early in ramstage
......................................................................

Patch Set 3:

Development ceased until haswell/broadwell directory moves are merged.

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42463 )

Change subject: [WIP] ACPI: Allocate GNVS early in ramstage
......................................................................

Patch Set 4: Code-Review+1
> Patch Set 3:
>
> Development ceased until haswell/broadwell directory moves are merged.

It will take way longer than I expected. I'd rather get this merged in first.

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42463 )

Change subject: [WIP] ACPI: Allocate GNVS early in ramstage
......................................................................

Abandoned