Tim Crawford has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80755?usp=email )
Change subject: mb/system76/adl: Remove duplicate PchHdaAudioLinkHdaEnable ......................................................................
mb/system76/adl: Remove duplicate PchHdaAudioLinkHdaEnable
This UPD is hooked up in devicetree since commit 854bd492fcfa ("mb/{system76,msi}: Enable PchHdaAudioLinkHdaEnable via devicetree").
As these boards were in development when the change happened, they still had the UPD set via romstage. Remove them now so they are only set in devicetree.
Change-Id: I393e2c7b0134a31feae20f8992d7fd447ff7ee59 Signed-off-by: Tim Crawford tcrawford@system76.com --- M src/mainboard/system76/adl/variants/lemp11/romstage.c M src/mainboard/system76/adl/variants/oryp10/romstage.c M src/mainboard/system76/adl/variants/oryp9/romstage.c 3 files changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/80755/1
diff --git a/src/mainboard/system76/adl/variants/lemp11/romstage.c b/src/mainboard/system76/adl/variants/lemp11/romstage.c index 989b5df..211ab97 100644 --- a/src/mainboard/system76/adl/variants/lemp11/romstage.c +++ b/src/mainboard/system76/adl/variants/lemp11/romstage.c @@ -15,7 +15,6 @@ }; const bool half_populated = false;
- mupd->FspmConfig.PchHdaAudioLinkHdaEnable = 1; mupd->FspmConfig.DmiMaxLinkSpeed = 4; mupd->FspmConfig.GpioOverride = 0;
diff --git a/src/mainboard/system76/adl/variants/oryp10/romstage.c b/src/mainboard/system76/adl/variants/oryp10/romstage.c index 48714e0..86ecf32 100644 --- a/src/mainboard/system76/adl/variants/oryp10/romstage.c +++ b/src/mainboard/system76/adl/variants/oryp10/romstage.c @@ -23,7 +23,6 @@ // Set primary display to internal graphics mupd->FspmConfig.PrimaryDisplay = 0;
- mupd->FspmConfig.PchHdaAudioLinkHdaEnable = 1; mupd->FspmConfig.DmiMaxLinkSpeed = 4; mupd->FspmConfig.GpioOverride = 0;
diff --git a/src/mainboard/system76/adl/variants/oryp9/romstage.c b/src/mainboard/system76/adl/variants/oryp9/romstage.c index d16b4f8..5e6cf7d 100644 --- a/src/mainboard/system76/adl/variants/oryp9/romstage.c +++ b/src/mainboard/system76/adl/variants/oryp9/romstage.c @@ -20,7 +20,6 @@ // Set primary display to internal graphics mupd->FspmConfig.PrimaryDisplay = 0;
- mupd->FspmConfig.PchHdaAudioLinkHdaEnable = 1; mupd->FspmConfig.DmiMaxLinkSpeed = 4; mupd->FspmConfig.GpioOverride = 0;