Vladimir Serbinenko has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86246?usp=email )
Change subject: acpi: Zero-out MADT before filling it ......................................................................
acpi: Zero-out MADT before filling it
Otherwise flags field is pre-filled with random garbage.
Change-Id: Ie5dc0720183b8ba07561341003f28a86ffce911e --- M 3rdparty/arm-trusted-firmware M 3rdparty/blobs M 3rdparty/fsp M 3rdparty/intel-microcode M 3rdparty/vboot M src/acpi/acpi.c 6 files changed, 7 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/86246/1
diff --git a/3rdparty/arm-trusted-firmware b/3rdparty/arm-trusted-firmware index 15e5c6c..48f1bc9 160000 --- a/3rdparty/arm-trusted-firmware +++ b/3rdparty/arm-trusted-firmware @@ -1 +1 @@ -Subproject commit 15e5c6c91d483aa52908154cc80e48956e234232 +Subproject commit 48f1bc9f52491d51ca92a1d396ccbe6a9d09e780 diff --git a/3rdparty/blobs b/3rdparty/blobs index 14f8fcc..a8db7df 160000 --- a/3rdparty/blobs +++ b/3rdparty/blobs @@ -1 +1 @@ -Subproject commit 14f8fcc1b426cb0884a21a9b715da6e0c1c7f434 +Subproject commit a8db7dfe823def043368857b8fbfbba86f2e9e47 diff --git a/3rdparty/fsp b/3rdparty/fsp index 15c0f7b..cc6399e 160000 --- a/3rdparty/fsp +++ b/3rdparty/fsp @@ -1 +1 @@ -Subproject commit 15c0f7b3f723bcd713e5ab11ebc502f30d9084e7 +Subproject commit cc6399e8c759ad4ed83c2d6ea568fd918fc9bc06 diff --git a/3rdparty/intel-microcode b/3rdparty/intel-microcode index 8ac9378..5278dfc 160000 --- a/3rdparty/intel-microcode +++ b/3rdparty/intel-microcode @@ -1 +1 @@ -Subproject commit 8ac9378a84879e81c503e09f344560b3dd7f72df +Subproject commit 5278dfcf98e89098326b3eb8a85d07120a8730f8 diff --git a/3rdparty/vboot b/3rdparty/vboot index 3f94e2c..09fcd21 160000 --- a/3rdparty/vboot +++ b/3rdparty/vboot @@ -1 +1 @@ -Subproject commit 3f94e2c7ed58c4e67d6e7dc6052ec615dbbb9bb4 +Subproject commit 09fcd2184f9c714829503e84b8a7dfe7f2584e00 diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index ffd9b79..8f5c09f 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -138,6 +138,8 @@ acpi_madt_t *madt = (acpi_madt_t *)header; unsigned long current = (unsigned long)madt + sizeof(acpi_madt_t);
+ memset(madt, 0, sizeof(*madt)); + if (acpi_fill_header(header, "APIC", MADT, sizeof(acpi_madt_t)) != CB_SUCCESS) return;