Change in coreboot[master]: mb/system76/lemp9: enable c6dram

List overview All Threads
Download

newer

older

[M] Change in coreboot[master]:...

[XS] Change in coreboot[master]:...

Jeremy Soller (Code Review)

20 Jul 2020 20 Jul '20

11:32 p.m.

Jeremy Soller has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43625 )

Change subject: mb/system76/lemp9: enable c6dram ......................................................................

mb/system76/lemp9: enable c6dram

Tested on lemp9

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I9b19ad704096571f2a62f4e39051e52a720f393b --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/43625/1

diff --git a/src/mainboard/system76/lemp9/devicetree.cb b/src/mainboard/system76/lemp9/devicetree.cb index 3a158ed..8d77aa9 100644 --- a/src/mainboard/system76/lemp9/devicetree.cb +++ b/src/mainboard/system76/lemp9/devicetree.cb @@ -37,7 +37,7 @@

# FSP Memory (soc/intel/cannonlake/romstage/fsp_params.c) register "SaGv" = "SaGv_Enabled" - #register "enable_c6dram" = "1" + register "enable_c6dram" = "1"

# FSP Silicon (soc/intel/cannonlake/fsp_params.c) # Serial I/O

Attachments:

attachment.htm (text/html — 2.5 KB)

Show replies by date

Angel Pons (Code Review)

21 Jul 21 Jul

midnight

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43625 )

Change subject: mb/system76/lemp9: enable c6dram ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43625/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43625/4//COMMIT_MSG@9 PS4, Line 9: Tested on lemp9 I couldn't find much info about C6DRAM. Would be good to know what the expected change would be.

In any case, please add a period at the end of the sentence.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43625 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b19ad704096571f2a62f4e39051e52a720f393b Gerrit-Change-Number: 43625 Gerrit-PatchSet: 4 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Mon, 20 Jul 2020 22:00:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jeremy Soller (Code Review)

12:02 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43625

to look at the new patch set (#7).

Change subject: mb/system76/lemp9: enable c6dram ......................................................................

mb/system76/lemp9: enable c6dram

Tested on lemp9

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I9b19ad704096571f2a62f4e39051e52a720f393b --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/43625/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/43625 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b19ad704096571f2a62f4e39051e52a720f393b Gerrit-Change-Number: 43625 Gerrit-PatchSet: 7 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: newpatchset

Jeremy Soller (Code Review)

12:11 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43625

to look at the new patch set (#8).

Change subject: mb/system76/lemp9: enable c6dram ......................................................................

mb/system76/lemp9: enable c6dram

Tested on lemp9.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I9b19ad704096571f2a62f4e39051e52a720f393b --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/43625/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/43625 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b19ad704096571f2a62f4e39051e52a720f393b Gerrit-Change-Number: 43625 Gerrit-PatchSet: 8 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: newpatchset

Jeremy Soller (Code Review)

4:20 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43625

to look at the new patch set (#12).

Change subject: mb/system76/lemp9: enable c6dram ......................................................................

mb/system76/lemp9: enable c6dram

Tested on lemp9.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I9b19ad704096571f2a62f4e39051e52a720f393b --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/43625/12

-- To view, visit https://review.coreboot.org/c/coreboot/+/43625 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b19ad704096571f2a62f4e39051e52a720f393b Gerrit-Change-Number: 43625 Gerrit-PatchSet: 12 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Michael Niewöhner (Code Review)

11:44 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43625 )

Change subject: mb/system76/lemp9: enable c6dram ......................................................................

Patch Set 15: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43625 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b19ad704096571f2a62f4e39051e52a720f393b Gerrit-Change-Number: 43625 Gerrit-PatchSet: 15 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 21 Jul 2020 21:44:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Jeremy Soller (Code Review)

22 Jul 22 Jul

2:45 p.m.

Hello build bot (Jenkins), Michael Niewöhner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43625

to look at the new patch set (#16).

Change subject: mb/system76/lemp9: enable c6dram ......................................................................

mb/system76/lemp9: enable c6dram

Tested on lemp9.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I9b19ad704096571f2a62f4e39051e52a720f393b --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/43625/16

-- To view, visit https://review.coreboot.org/c/coreboot/+/43625 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b19ad704096571f2a62f4e39051e52a720f393b Gerrit-Change-Number: 43625 Gerrit-PatchSet: 16 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Jeremy Soller (Code Review)

4:09 p.m.

Hello build bot (Jenkins), Michael Niewöhner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43625

to look at the new patch set (#18).

Change subject: mb/system76/lemp9: enable c6dram ......................................................................

mb/system76/lemp9: enable c6dram

Tested on lemp9.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I9b19ad704096571f2a62f4e39051e52a720f393b --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/43625/18

-- To view, visit https://review.coreboot.org/c/coreboot/+/43625 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b19ad704096571f2a62f4e39051e52a720f393b Gerrit-Change-Number: 43625 Gerrit-PatchSet: 18 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Michael Niewöhner (Code Review)

6 Sep 6 Sep

4:46 p.m.

Michael Niewöhner has uploaded a new patch set (#20) to the change originally created by Jeremy Soller. ( https://review.coreboot.org/c/coreboot/+/43625 )

Change subject: mb/system76/lemp9: enable c6dram ......................................................................

mb/system76/lemp9: enable c6dram

This feature enables moving DRAM contents to PRM memory when the CPU is in C6 state.

Tested on lemp9.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I9b19ad704096571f2a62f4e39051e52a720f393b --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/43625/20

-- To view, visit https://review.coreboot.org/c/coreboot/+/43625 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b19ad704096571f2a62f4e39051e52a720f393b Gerrit-Change-Number: 43625 Gerrit-PatchSet: 20 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Michael Niewöhner (Code Review)

4:46 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43625 )

Change subject: mb/system76/lemp9: enable c6dram ......................................................................

Patch Set 20:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43625/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43625/4//COMMIT_MSG@9 PS4, Line 9: Tested on lemp9

...

I couldn't find much info about C6DRAM. Would be good to know what the expected change would be. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/43625 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b19ad704096571f2a62f4e39051e52a720f393b Gerrit-Change-Number: 43625 Gerrit-PatchSet: 20 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 06 Sep 2020 14:46:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

7 Sep 7 Sep

9:58 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43625 )

Change subject: mb/system76/lemp9: enable c6dram ......................................................................

Patch Set 20: -Code-Review

-- To view, visit https://review.coreboot.org/c/coreboot/+/43625 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b19ad704096571f2a62f4e39051e52a720f393b Gerrit-Change-Number: 43625 Gerrit-PatchSet: 20 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 07 Sep 2020 19:58:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

9:59 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43625 )

Change subject: mb/system76/lemp9: enable c6dram ......................................................................

Patch Set 20:

We need to find out, what C6DRAM really does... seems to have to do with SGX and PRM somehow

-- To view, visit https://review.coreboot.org/c/coreboot/+/43625 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b19ad704096571f2a62f4e39051e52a720f393b Gerrit-Change-Number: 43625 Gerrit-PatchSet: 20 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 07 Sep 2020 19:59:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

15 Sep 15 Sep

12:39 p.m.

Michael Niewöhner has uploaded a new patch set (#21) to the change originally created by Jeremy Soller. ( https://review.coreboot.org/c/coreboot/+/43625 )

Change subject: mb/system76/lemp9: enable c6dram ......................................................................

mb/system76/lemp9: enable c6dram

From Intel doc# 615211-005: The C6DRAM feature saves the processor internal state at Package C6 and deeper to DRAM instead of on-die SRAM. When the processor state has been saved to DRAM , the dedicated save/restore SRAM modules are power gated, enabling idle power savings.

Tested on lemp9.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I9b19ad704096571f2a62f4e39051e52a720f393b --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/43625/21

-- To view, visit https://review.coreboot.org/c/coreboot/+/43625 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b19ad704096571f2a62f4e39051e52a720f393b Gerrit-Change-Number: 43625 Gerrit-PatchSet: 21 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Michael Niewöhner (Code Review)

12:39 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43625 )

Change subject: mb/system76/lemp9: enable c6dram ......................................................................

Patch Set 21:

Updated the commit message.

I wonder if we should set c6dram=1 statically in soc/cnl?

-- To view, visit https://review.coreboot.org/c/coreboot/+/43625 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b19ad704096571f2a62f4e39051e52a720f393b Gerrit-Change-Number: 43625 Gerrit-PatchSet: 21 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 15 Sep 2020 10:39:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

12:40 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43625 )

Change subject: mb/system76/lemp9: enable c6dram ......................................................................

Patch Set 21: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43625 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b19ad704096571f2a62f4e39051e52a720f393b Gerrit-Change-Number: 43625 Gerrit-PatchSet: 21 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 15 Sep 2020 10:40:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

17 Sep 17 Sep

11:46 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43625 )

Change subject: mb/system76/lemp9: enable c6dram ......................................................................

Patch Set 21: Code-Review-1

-1 again, until we found out when it really saves power.. I couldn't get lower power usage in powertop and C6 enforced, yet

-- To view, visit https://review.coreboot.org/c/coreboot/+/43625 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b19ad704096571f2a62f4e39051e52a720f393b Gerrit-Change-Number: 43625 Gerrit-PatchSet: 21 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 17 Sep 2020 21:46:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Jeremy Soller (Code Review)

2 Aug 2 Aug

9:01 p.m.

New subject: [XS] Change in coreboot[master]: mb/system76/lemp9: enable c6dram

Jeremy Soller has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43625?usp=email )

Change subject: mb/system76/lemp9: enable c6dram ......................................................................

Abandoned

This change is stale.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43625?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b19ad704096571f2a62f4e39051e52a720f393b Gerrit-Change-Number: 43625 Gerrit-PatchSet: 21 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-MessageType: abandon

479

days inactive

1587

days old

coreboot-gerrit@coreboot.org

16 comments

3 participants

tags (0)

participants (3)

Angel Pons (Code Review)
Jeremy Soller (Code Review)
Michael Niewöhner (Code Review)