Change in ...coreboot[master]: src/arch/x86/acpi.c: Update SRAT revision number

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

HAOUAS Elyes (Code Review)

22 Feb 2019 22 Feb '19

11:19 a.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31565

Change subject: src/arch/x86/acpi.c: Update SRAT revision number ......................................................................

src/arch/x86/acpi.c: Update SRAT revision number

We currently use ACPI v3.0, so the SRAT revision number is "2".

Change-Id: I14311029c887a2260c3a93d0b7fca6e8d546edd0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/x86/acpi.c 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/31565/1

diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c index 6396877..fc9dfe1 100644 --- a/src/arch/x86/acpi.c +++ b/src/arch/x86/acpi.c @@ -1383,8 +1383,8 @@ return 4; case SSDT: /* ACPI 3.0 upto 6.3: 2 */ return 2; - case SRAT: /* ACPI 2.0: 1, ACPI 3.0: 2, ACPI 4.0 upto 6.3: 3 */ - return 1; /* TODO Should probably be upgraded to 2 */ + case SRAT: /* ACPI 3.0: 2, ACPI 4.0 upto 6.3: 3 */ + return 2; case DMAR: return 1; case SLIT: /* ACPI 2.0 upto 6.3: 1 */

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

HAOUAS Elyes (Code Review)

22 Feb 22 Feb

11:24 a.m.

New subject: Change in ...coreboot[master]: src/arch/x86/acpi.c: Upgrade SRAT revision number

HAOUAS Elyes has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/31565 )

Change subject: src/arch/x86/acpi.c: Upgrade SRAT revision number ......................................................................

src/arch/x86/acpi.c: Upgrade SRAT revision number

We currently use ACPI v3.0, so the SRAT revision number is "2".

Change-Id: I14311029c887a2260c3a93d0b7fca6e8d546edd0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/x86/acpi.c 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/31565/2

Paul Menzel (Code Review)

3:56 p.m.

New subject: Change in ...coreboot[master]: src/arch/x86/acpi.c: Upgrade SRAT revision number

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31565 )

Change subject: src/arch/x86/acpi.c: Upgrade SRAT revision number ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/31565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14311029c887a2260c3a93d0b7fca6e8d546edd0 Gerrit-Change-Number: 31565 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 22 Feb 2019 14:56:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

27 Feb 27 Feb

1:57 p.m.

New subject: Change in ...coreboot[master]: src/arch/x86/acpi.c: Upgrade SRAT revision number

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31565 )

Change subject: src/arch/x86/acpi.c: Upgrade SRAT revision number ......................................................................

Patch Set 2:

you must update the corresponding structs as well:

struct acpi_srat_lapic struct acpi_srat_mem

Some fields are now reserved, and some where added.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14311029c887a2260c3a93d0b7fca6e8d546edd0 Gerrit-Change-Number: 31565 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 27 Feb 2019 12:57:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

28 Feb 28 Feb

12:56 p.m.

New subject: Change in ...coreboot[master]: src/arch/x86/acpi.c: Upgrade SRAT revision number

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31565 )

Change subject: src/arch/x86/acpi.c: Upgrade SRAT revision number ......................................................................

Patch Set 2:

...

you must update the corresponding structs as well:

struct acpi_srat_lapic struct acpi_srat_mem

Some fields are now reserved, and some where added.

Maybe I'm wrong, but I've checked 6.3 specs, and they are upto date.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14311029c887a2260c3a93d0b7fca6e8d546edd0 Gerrit-Change-Number: 31565 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 28 Feb 2019 11:56:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

1:09 p.m.

New subject: Change in ...coreboot[master]: src/arch/x86/acpi.c: Upgrade SRAT revision number

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31565 )

Change subject: src/arch/x86/acpi.c: Upgrade SRAT revision number ......................................................................

Patch Set 2:

You must check the spec that implements SRAT revision "2". That is ACPI 3.0.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14311029c887a2260c3a93d0b7fca6e8d546edd0 Gerrit-Change-Number: 31565 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 28 Feb 2019 12:09:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

1:27 p.m.

New subject: Change in ...coreboot[master]: src/arch/x86/acpi.c: Upgrade SRAT revision number

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31565 )

Change subject: src/arch/x86/acpi.c: Upgrade SRAT revision number ......................................................................

Patch Set 2:

...

You must check the spec that implements SRAT revision "2". That is ACPI 3.0.

Seems the same... maybe the version I have ( V3.0 from http://www.acpi.info/ ) is wrong.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14311029c887a2260c3a93d0b7fca6e8d546edd0 Gerrit-Change-Number: 31565 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 28 Feb 2019 12:27:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

1:46 p.m.

New subject: Change in ...coreboot[master]: src/arch/x86/acpi.c: Upgrade SRAT revision number

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31565 )

Change subject: src/arch/x86/acpi.c: Upgrade SRAT revision number ......................................................................

Patch Set 2:

I misread it. The only change I see now:

acpi_srat_lapic.clock_domain is reserved in revision 2, wasn't in revision 1

-- To view, visit https://review.coreboot.org/c/coreboot/+/31565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14311029c887a2260c3a93d0b7fca6e8d546edd0 Gerrit-Change-Number: 31565 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 28 Feb 2019 12:46:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

2 Mar 2 Mar

8:47 p.m.

New subject: Change in ...coreboot[master]: src/arch/x86/acpi.c: Upgrade SRAT revision number

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31565 )

Change subject: src/arch/x86/acpi.c: Upgrade SRAT revision number ......................................................................

Patch Set 2:

...

I misread it. The only change I see now:

acpi_srat_lapic.clock_domain is reserved in revision 2, wasn't in revision 1

indeed, I've changed 'u32 resv' to 'u32 clock_domain' at Change-Id: I91291c8

-- To view, visit https://review.coreboot.org/c/coreboot/+/31565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14311029c887a2260c3a93d0b7fca6e8d546edd0 Gerrit-Change-Number: 31565 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 02 Mar 2019 19:47:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

13 Apr 13 Apr

10:27 a.m.

New subject: Change in ...coreboot[master]: src/arch/x86/acpi.c: Upgrade SRAT revision number

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31565 )

Change subject: src/arch/x86/acpi.c: Upgrade SRAT revision number ......................................................................

Patch Set 3: Code-Review-1

acpi_srat_lapic.clock_domain is reserved in revision 2, wasn't in revision 1

-- To view, visit https://review.coreboot.org/c/coreboot/+/31565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14311029c887a2260c3a93d0b7fca6e8d546edd0 Gerrit-Change-Number: 31565 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 13 Apr 2019 08:27:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

12:47 p.m.

New subject: Change in ...coreboot[master]: src/arch/x86/acpi.c: Upgrade SRAT revision number

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31565 )

Change subject: src/arch/x86/acpi.c: Upgrade SRAT revision number ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/31565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14311029c887a2260c3a93d0b7fca6e8d546edd0 Gerrit-Change-Number: 31565 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: abandon

HAOUAS Elyes (Code Review)

12:50 p.m.

New subject: Change in ...coreboot[master]: src/arch/x86/acpi.c: Upgrade SRAT revision number

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31565 )

Change subject: src/arch/x86/acpi.c: Upgrade SRAT revision number ......................................................................

Patch Set 3:

I think that clock_domain is reserved in version 1 not 2.

anyway, this change is not a big deal as we still using old acpi version.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14311029c887a2260c3a93d0b7fca6e8d546edd0 Gerrit-Change-Number: 31565 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 13 Apr 2019 10:50:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

1 p.m.

New subject: Change in ...coreboot[master]: src/arch/x86/acpi.c: Upgrade SRAT revision number

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31565 )

Change subject: src/arch/x86/acpi.c: Upgrade SRAT revision number ......................................................................

Patch Set 3:

...

I think that clock_domain is reserved in version 1 not 2.

oops, reserved in 2

it was added since version 3

...

anyway, this change is not a big deal as we still using old acpi version.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14311029c887a2260c3a93d0b7fca6e8d546edd0 Gerrit-Change-Number: 31565 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 13 Apr 2019 11:00:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2051

days inactive

2101

days old

coreboot-gerrit@coreboot.org

12 comments

3 participants

tags (0)

participants (3)

HAOUAS Elyes (Code Review)
Patrick Rudolph (Code Review)
Paul Menzel (Code Review)