Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85188?usp=email )
Change subject: soc/mediatek/mt8196: Add MMinfra driver support
......................................................................
Patch Set 26:
(1 comment)
File src/soc/mediatek/mt8196/mminfra.c:
https://review.coreboot.org/c/coreboot/+/85188/comment/d805e535_30f9aa78?usp... :
PS26, Line 110: int ret;
:
: /* mminfra0 */
: ret = mtcmos_cb_register(MTCMOS_ID_MM_INFRA0, &mm_infra0_pb_cb);
: if (ret)
: return;
:
: /* mminfra1 */
: ret = mtcmos_cb_register(MTCMOS_ID_MM_INFRA1, &mm_infra1_pb_cb);
: if (ret)
: return;
: }
```
if (mtcmos_cb_register(MTCMOS_ID_MM_INFRA0, &mm_infra0_pb_cb))
return;
mtcmos_cb_register(MTCMOS_ID_MM_INFRA1, &mm_infra1_pb_cb);
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85188?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie86f141a0957fc60d4973875c0dbcbdb57be1f75
Gerrit-Change-Number: 85188
Gerrit-PatchSet: 26
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 16 Dec 2024 09:21:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No