Lucas Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45289 )
Change subject: mb/google/kukui: add support different ram table for Willow ......................................................................
mb/google/kukui: add support different ram table for Willow
Add support different ram id table base on board_id.
BUG=b:160288021 BRANCH=kukui TEST=emerge-jacuzzi coreboot
Signed-off-by: Lucas Chen lucas.chen@quanta.corp-partner.google.com Change-Id: Icee922c647774f755d41bc3c37f6a0d5ffc35df1 --- M src/mainboard/google/kukui/boardid.c 1 file changed, 11 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/45289/1
diff --git a/src/mainboard/google/kukui/boardid.c b/src/mainboard/google/kukui/boardid.c old mode 100644 new mode 100755 index 548f36b..546247e --- a/src/mainboard/google/kukui/boardid.c +++ b/src/mainboard/google/kukui/boardid.c @@ -112,8 +112,17 @@
if (cached_ram_code == BOARD_ID_INIT) { cached_ram_code = get_adc_index(RAM_ID_CHANNEL); - /* Model-specific offset - see sdram_configs.c for details. */ - cached_ram_code += CONFIG_BOARD_SDRAM_TABLE_OFFSET; + /* Quirk for Willow: All Rev greater then 5 set SDRAM TABLE OFFSET=0x10. */ + if (CONFIG(BOARD_GOOGLE_WILLOW)) { + if (board_id() >= 6) { + cached_ram_code += 0x10; + } + else + cached_ram_code += CONFIG_BOARD_SDRAM_TABLE_OFFSET; + } + else + /* Model-specific offset - see sdram_configs.c for details. */ + cached_ram_code += CONFIG_BOARD_SDRAM_TABLE_OFFSET; } return cached_ram_code; }
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45289 )
Change subject: mb/google/kukui: add support different ram table for Willow ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45289/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/boardid.c:
https://review.coreboot.org/c/coreboot/+/45289/1/src/mainboard/google/kukui/... PS1, Line 117: if (board_id() >= 6) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/45289/1/src/mainboard/google/kukui/... PS1, Line 120: else else should follow close brace '}'
https://review.coreboot.org/c/coreboot/+/45289/1/src/mainboard/google/kukui/... PS1, Line 123: else else should follow close brace '}'
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45289
to look at the new patch set (#2).
Change subject: mb/google/kukui: add support different ram table for Willow ......................................................................
mb/google/kukui: add support different ram table for Willow
Add support different ram id table base on board_id.
BUG=b:160288021 BRANCH=kukui TEST=emerge-jacuzzi coreboot
Signed-off-by: Lucas Chen lucas.chen@quanta.corp-partner.google.com Change-Id: Icee922c647774f755d41bc3c37f6a0d5ffc35df1 --- M src/mainboard/google/kukui/boardid.c 1 file changed, 9 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/45289/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45289 )
Change subject: mb/google/kukui: add support different ram table for Willow ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45289/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45289/2//COMMIT_MSG@9 PS2, Line 9: Add support different ram id table base on board_id. Please describe the requirements in the commit message.
https://review.coreboot.org/c/coreboot/+/45289/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/boardid.c:
https://review.coreboot.org/c/coreboot/+/45289/2/src/mainboard/google/kukui/... PS2, Line 115: Rev revs
https://review.coreboot.org/c/coreboot/+/45289/2/src/mainboard/google/kukui/... PS2, Line 115: then than
https://review.coreboot.org/c/coreboot/+/45289/2/src/mainboard/google/kukui/... PS2, Line 123: cached_ram_code += CONFIG_BOARD_SDRAM_TABLE_OFFSET; Please add braces around the else branch.
https://doc.coreboot.org/coding_style.html
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45289 )
Change subject: mb/google/kukui: add support different ram table for Willow ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45289/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/boardid.c:
https://review.coreboot.org/c/coreboot/+/45289/2/src/mainboard/google/kukui/... PS2, Line 117: if (board_id() >= 6) : cached_ram_code += 0x10; : else : cached_ram_code += CONFIG_BOARD_SDRAM_TABLE_OFFSET; I would suggest to reverse the check because it can make sure the succeeding phase using the correct CONFIG_BOARD_SDRAM_TABLE_OFFSET value. So, please change to
if (board_id() >= 6) cached_ram_code += CONFIG_BOARD_SDRAM_TABLE_OFFSET;
and change the CONFIG_BOARD_SDRAM_TABLE_OFFSET in the Kconfig.
Hello Hung-Te Lin, build bot (Jenkins), Pan Sheng-Liang, Tim Chen, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45289
to look at the new patch set (#3).
Change subject: mb/google/kukui: add support different ram table for Willow ......................................................................
mb/google/kukui: add support different ram table for Willow
Add support different ram id table base on board_id for Willow board_id >= 6 , ram table index += 0x10 board_id < 6 , ram table index += 0x0 for original table
BUG=b:160288021 BRANCH=kukui TEST=emerge-jacuzzi coreboot
Signed-off-by: Lucas Chen lucas.chen@quanta.corp-partner.google.com Change-Id: Icee922c647774f755d41bc3c37f6a0d5ffc35df1 --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/boardid.c 2 files changed, 11 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/45289/3
Lucas Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45289 )
Change subject: mb/google/kukui: add support different ram table for Willow ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45289/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/boardid.c:
https://review.coreboot.org/c/coreboot/+/45289/2/src/mainboard/google/kukui/... PS2, Line 115: Rev
revs
Done.
https://review.coreboot.org/c/coreboot/+/45289/2/src/mainboard/google/kukui/... PS2, Line 115: then
than
Done.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45289 )
Change subject: mb/google/kukui: add support different ram table for Willow ......................................................................
Patch Set 3:
Please hold on this CL review because we have some discussion in b:160288021
Lucas Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45289 )
Change subject: mb/google/kukui: add support different ram table for Willow ......................................................................
Patch Set 3: Code-Review-1
Attention is currently required from: Lucas Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45289 )
Change subject: mb/google/kukui: add support different ram table for Willow ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3: Since b/160288021 has been fixed, please abandon this patch.
Lucas Chen has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45289 )
Change subject: mb/google/kukui: add support different ram table for Willow ......................................................................
Abandoned
-
build bot (Jenkins) (Code Review) -
Lucas Chen (Code Review)
-
Paul Menzel (Code Review)
-
Yu-Ping Wu (Code Review)
-
Zhuohao Lee (Code Review)