Attention is currently required from: Ivy Jian, Nick Vaccaro.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79391?usp=email )
Change subject: mb/google/brox: Update configuration for USB ports
......................................................................
Patch Set 1:
(3 comments)
File src/mainboard/google/brox/variants/brox/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/79391/comment/07cd0238_8ed7992a :
PS1, Line 81: end
Missing port A0 config
https://review.coreboot.org/c/coreboot/+/79391/comment/6aecac68_5e737189 :
PS1, Line 84: register "type" = "UPC_TYPE_INTERNAL"
has_power_resource = 1?
https://review.coreboot.org/c/coreboot/+/79391/comment/b0a94e30_174d8aeb :
PS1, Line 87: end
Similarly missing USB3 config for port A0.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79391?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iac5a2e8be6cea64f107d267d4cf71529f08bb63d
Gerrit-Change-Number: 79391
Gerrit-PatchSet: 1
Gerrit-Owner: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Tue, 05 Dec 2023 23:49:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment