Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40308 )
Change subject: mb/ocp/tiogapass: Override SMBIOS data ......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40308/14/src/mainboard/ocp/tiogapas... File src/mainboard/ocp/tiogapass/ramstage.c:
https://review.coreboot.org/c/coreboot/+/40308/14/src/mainboard/ocp/tiogapas... PS14, Line 33: const char *smbios_system_manufacturer(void)
vendorcode is for code that shouldn't be modified because there's a canonical source for it somewher […]
Setting SMBIOS data is not OCP server specific. It is necessary for all servers, and not just servers. The data may come from BMC (when the mainboard has BMC), or from VPD (when the mainboard does not have BMC, such as chromebook), or from configuration. Therefore, a better choice might be src/lib, and create a new file (proposed name: smbios.c).
-
Jonathan Zhang (Code Review)