Attention is currently required from: Filip Lewiński, Jérémy Compostella.
Paul Menzel has posted comments on this change by Filip Lewiński. ( https://review.coreboot.org/c/coreboot/+/82696?usp=email )
Change subject: cpu/x86/mp_init: Add code to restart APs ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82696/comment/41e6374f_ea91979c?usp... : PS1, Line 8: Please elaborate, why this is needed.
File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/82696/comment/98b0d0c0_80a9a3bf?usp... : PS1, Line 1209: /* Make sure SIPI data hits RAM so the APs that come up will see : * the startup code even if the caches are disabled. */ Please use the recommended multi-line commenting styles [1].
[1]: https://doc.coreboot.org/contributing/coding_style.html#commenting
https://review.coreboot.org/c/coreboot/+/82696/comment/5fae32c8_8d43e4ed?usp... : PS1, Line 1214: mdelay(1000); That’s quite a long delay. Please add a comment, what demands that.