Change in coreboot[master]: asus/p2b-ls: Replicate OEM GPO/PM configurations

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Keith Hui (Code Review)

11 Jan 2020 11 Jan '20

9:54 a.m.

Keith Hui has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38354 )

Change subject: asus/p2b-ls: Replicate OEM GPO/PM configurations ......................................................................

asus/p2b-ls: Replicate OEM GPO/PM configurations

Replicate the entire GPO/lid/thermal configuration from OEM BIOS. Among the GPOs are termination controls for the onboard SCSI buses.

Requires /c/38352 to function.

Change-Id: I86183acd8e1a830d7639c21ec179fbdbe937f8ee Signed-off-by: Keith Hui buurin@gmail.com --- M src/mainboard/asus/p2b-ls/devicetree.cb 1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/38354/1

diff --git a/src/mainboard/asus/p2b-ls/devicetree.cb b/src/mainboard/asus/p2b-ls/devicetree.cb index a9901b4..5e55278 100644 --- a/src/mainboard/asus/p2b-ls/devicetree.cb +++ b/src/mainboard/asus/p2b-ls/devicetree.cb @@ -8,6 +8,10 @@ device pci 0.0 on end # Host bridge device pci 1.0 on end # PCI/AGP bridge chip southbridge/intel/i82371eb # Southbridge + register "gpo" = "0x7fbfb9ff" + register "gpo22_enable" = "1" + register "lid_polarity" = "1" + register "thrm_polarity" = "1" device pci 4.0 on # ISA bridge chip superio/winbond/w83977tf # Super I/O (FIXME: It's W83977EF!) device pnp 3f0.0 on # Floppy

Attachments:

attachment.htm (text/html — 2.9 KB)

Show replies by date

Keith Hui (Code Review)

11 Jan 11 Jan

7:54 p.m.

New subject: Change in coreboot[master]: asus/p2b-ls: Replicate OEM configurations

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38354

to look at the new patch set (#3).

Change subject: asus/p2b-ls: Replicate OEM configurations ......................................................................

asus/p2b-ls: Replicate OEM configurations

Replicate the entire GPO/lid/thermal configurations from OEM BIOS. Among the GPOs are termination controls for the onboard SCSI buses.

Requires /c/38352 to function.

Change-Id: I86183acd8e1a830d7639c21ec179fbdbe937f8ee Signed-off-by: Keith Hui buurin@gmail.com --- M src/mainboard/asus/p2b-ls/devicetree.cb 1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/38354/3

Angel Pons (Code Review)

11:17 p.m.

New subject: Change in coreboot[master]: asus/p2b-ls: Replicate OEM configurations

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38354 )

Change subject: asus/p2b-ls: Replicate OEM configurations ......................................................................

Patch Set 3: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/38354/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38354/3//COMMIT_MSG@9 PS3, Line 9: lid Is this board a laptop, or a trash can? I don't think it would have a lid.

https://review.coreboot.org/c/coreboot/+/38354/3//COMMIT_MSG@12 PS3, Line 12: Requires /c/38352 to function. This is redundant, since the changes were pushed as a patch train.

Keith Hui (Code Review)

12 Jan 12 Jan

2:53 a.m.

New subject: Change in coreboot[master]: asus/p2b-ls: Replicate OEM configurations

Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38354 )

Change subject: asus/p2b-ls: Replicate OEM configurations ......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38354/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38354/3//COMMIT_MSG@9 PS3, Line 9: lid

...

Is this board a laptop, or a trash can? I don't think it would have a lid.

LOL... It's a desktop board, but does have a port where one can connect a switch to sense when the case housing the board is opened.

https://review.coreboot.org/c/coreboot/+/38354/3//COMMIT_MSG@12 PS3, Line 12: Requires /c/38352 to function.

...

This is redundant, since the changes were pushed as a patch train.

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/38354 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86183acd8e1a830d7639c21ec179fbdbe937f8ee Gerrit-Change-Number: 38354 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 12 Jan 2020 01:53:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Keith Hui (Code Review)

2:59 a.m.

New subject: Change in coreboot[master]: asus/p2b-ls: Replicate OEM configurations

Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38354 )

Change subject: asus/p2b-ls: Replicate OEM configurations ......................................................................

Patch Set 3:

The entire patch train has been tested with a Atlas 10K III hard drive connected to the Ultra2 LVD port.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38354 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86183acd8e1a830d7639c21ec179fbdbe937f8ee Gerrit-Change-Number: 38354 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 12 Jan 2020 01:59:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

10:52 a.m.

New subject: Change in coreboot[master]: asus/p2b-ls: Replicate OEM configurations

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38354 )

Change subject: asus/p2b-ls: Replicate OEM configurations ......................................................................

Patch Set 3: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/38354/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38354/3//COMMIT_MSG@9 PS3, Line 9: lid

...

LOL... […]

Ah, yes, the case open switch. So, it might not be a laptop but can be like a Mac Pro with a lid open switch :^)

-- To view, visit https://review.coreboot.org/c/coreboot/+/38354 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86183acd8e1a830d7639c21ec179fbdbe937f8ee Gerrit-Change-Number: 38354 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 12 Jan 2020 09:52:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Keith Hui buurin@gmail.com Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Paul Menzel (Code Review)

13 Jan 13 Jan

12:11 p.m.

New subject: Change in coreboot[master]: asus/p2b-ls: Replicate OEM configurations

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38354 )

Change subject: asus/p2b-ls: Replicate OEM configurations ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38354/3/src/mainboard/asus/p2b-ls/d... File src/mainboard/asus/p2b-ls/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/38354/3/src/mainboard/asus/p2b-ls/d... PS3, Line 13: register "lid_polarity" = "1" What is that good for on a desktop board?

-- To view, visit https://review.coreboot.org/c/coreboot/+/38354 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86183acd8e1a830d7639c21ec179fbdbe937f8ee Gerrit-Change-Number: 38354 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 13 Jan 2020 11:11:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

12:12 p.m.

New subject: Change in coreboot[master]: asus/p2b-ls: Replicate OEM configurations

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38354 )

Change subject: asus/p2b-ls: Replicate OEM configurations ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38354/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38354/3//COMMIT_MSG@13 PS3, Line 13: Could you please document how you deduced the values?

-- To view, visit https://review.coreboot.org/c/coreboot/+/38354 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86183acd8e1a830d7639c21ec179fbdbe937f8ee Gerrit-Change-Number: 38354 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 13 Jan 2020 11:12:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

12:14 p.m.

New subject: Change in coreboot[master]: asus/p2b-ls: Replicate OEM configurations

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38354 )

Change subject: asus/p2b-ls: Replicate OEM configurations ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38354/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38354/3//COMMIT_MSG@13 PS3, Line 13:

...

Could you please document how you deduced the values?

Also, TEST= line, with what works now, would be nice.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38354 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86183acd8e1a830d7639c21ec179fbdbe937f8ee Gerrit-Change-Number: 38354 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 13 Jan 2020 11:14:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Angel Pons (Code Review)

15 Jan 15 Jan

12:19 a.m.

New subject: Change in coreboot[master]: asus/p2b-ls: Replicate OEM configurations

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38354 )

Change subject: asus/p2b-ls: Replicate OEM configurations ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38354/3/src/mainboard/asus/p2b-ls/d... File src/mainboard/asus/p2b-ls/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/38354/3/src/mainboard/asus/p2b-ls/d... PS3, Line 13: register "lid_polarity" = "1"

...

What is that good for on a desktop board?

See commit message comments. Though, if both of us had to answer the same question, maybe this needs a rename.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38354 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86183acd8e1a830d7639c21ec179fbdbe937f8ee Gerrit-Change-Number: 38354 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 14 Jan 2020 23:19:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Keith Hui (Code Review)

18 Jan 18 Jan

3:40 a.m.

New subject: Change in coreboot[master]: asus/p2b-ls: Replicate OEM configurations

Hello Angel Pons, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38354

to look at the new patch set (#4).

Change subject: asus/p2b-ls: Replicate OEM configurations ......................................................................

asus/p2b-ls: Replicate OEM configurations

Replicate the entire GPO/lid/thermal configurations from OEM BIOS. Among the GPOs are termination controls for the onboard SCSI buses.

TEST=read/write Maxtor Atlas 10k3 18GB HDD connected to Ultra2 LVD port

Change-Id: I86183acd8e1a830d7639c21ec179fbdbe937f8ee Signed-off-by: Keith Hui buurin@gmail.com --- M src/mainboard/asus/p2b-ls/devicetree.cb 1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/38354/4

Keith Hui (Code Review)

4 a.m.

New subject: Change in coreboot[master]: asus/p2b-ls: Replicate OEM configurations

Hello Angel Pons, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38354

to look at the new patch set (#5).

Change subject: asus/p2b-ls: Replicate OEM configurations ......................................................................

asus/p2b-ls: Replicate OEM configurations

Replicate the entire GPO/lid/thermal configurations from OEM BIOS, obtained via inteltool -a and lspci -nnvvvxxx while toggling SCSI bus termination settings. This GPO configuration enables onboard termination of the SCSI buses, allowing SCSI hard drives to be accessed.

TEST=read/write Maxtor Atlas 10k3 18GB HDD connected to Ultra2 LVD port

Change-Id: I86183acd8e1a830d7639c21ec179fbdbe937f8ee Signed-off-by: Keith Hui buurin@gmail.com --- M src/mainboard/asus/p2b-ls/devicetree.cb 1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/38354/5

Keith Hui (Code Review)

28 Jan 28 Jan

12:27 a.m.

New subject: Change in coreboot[master]: asus/p2b-ls: Replicate OEM configurations

Hello Angel Pons, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38354

to look at the new patch set (#6).

Change subject: asus/p2b-ls: Replicate OEM configurations ......................................................................

asus/p2b-ls: Replicate OEM configurations

Replicate the entire GPO/lid/thermal configurations from OEM BIOS. Among the GPOs are termination controls for the onboard SCSI buses.

TEST=read/write Maxtor Atlas 10k3 18GB HDD connected to Ultra2 LVD port

Change-Id: I86183acd8e1a830d7639c21ec179fbdbe937f8ee Signed-off-by: Keith Hui buurin@gmail.com --- M src/mainboard/asus/p2b-ls/devicetree.cb 1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/38354/6

Paul Menzel (Code Review)

1:43 p.m.

New subject: Change in coreboot[master]: asus/p2b-ls: Replicate OEM configurations

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38354 )

Change subject: asus/p2b-ls: Replicate OEM configurations ......................................................................

Patch Set 7: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/38354 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86183acd8e1a830d7639c21ec179fbdbe937f8ee Gerrit-Change-Number: 38354 Gerrit-PatchSet: 7 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 28 Jan 2020 12:43:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

2 Feb 2 Feb

1:15 p.m.

New subject: Change in coreboot[master]: asus/p2b-ls: Replicate OEM configurations

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38354 )

Change subject: asus/p2b-ls: Replicate OEM configurations ......................................................................

Patch Set 7: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/38354/3/src/mainboard/asus/p2b-ls/d... File src/mainboard/asus/p2b-ls/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/38354/3/src/mainboard/asus/p2b-ls/d... PS3, Line 13: register "lid_polarity" = "1"

...

See commit message comments. […]

See latest patchset

https://review.coreboot.org/c/coreboot/+/38354/7/src/mainboard/asus/p2b-ls/d... File src/mainboard/asus/p2b-ls/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/38354/7/src/mainboard/asus/p2b-ls/d... PS7, Line 13: lid_polarity Maybe call it "case_open_polarity" instead?

-- To view, visit https://review.coreboot.org/c/coreboot/+/38354 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86183acd8e1a830d7639c21ec179fbdbe937f8ee Gerrit-Change-Number: 38354 Gerrit-PatchSet: 7 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 02 Feb 2020 12:15:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Patrick Georgi (Code Review)

3 Mar 3 Mar

8:39 a.m.

New subject: Change in coreboot[master]: asus/p2b-ls: Replicate OEM configurations

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38354 )

Change subject: asus/p2b-ls: Replicate OEM configurations ......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38354/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38354/3//COMMIT_MSG@13 PS3, Line 13:

...

Also, TEST= line, with what works now, would be nice.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/38354 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86183acd8e1a830d7639c21ec179fbdbe937f8ee Gerrit-Change-Number: 38354 Gerrit-PatchSet: 9 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Tue, 03 Mar 2020 07:39:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Keith Hui (Code Review)

29 Mar 29 Mar

4:32 a.m.

New subject: Change in coreboot[master]: asus/p2b-ls: Replicate OEM GPO configuration

Hello build bot (Jenkins), Paul Menzel, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38354

to look at the new patch set (#10).

Change subject: asus/p2b-ls: Replicate OEM GPO configuration ......................................................................

asus/p2b-ls: Replicate OEM GPO configuration

Replicate the GPO configurations from OEM BIOS, obtained via inteltool. Among the GPOs are termination controls for the onboard SCSI buses.

TEST=read/write Maxtor Atlas 10k3 18GB HDD connected to Ultra2 LVD port

Change-Id: I86183acd8e1a830d7639c21ec179fbdbe937f8ee Signed-off-by: Keith Hui buurin@gmail.com --- M src/mainboard/asus/p2b/variants/p2b-ls/overridetree.cb 1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/38354/10

-- To view, visit https://review.coreboot.org/c/coreboot/+/38354 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86183acd8e1a830d7639c21ec179fbdbe937f8ee Gerrit-Change-Number: 38354 Gerrit-PatchSet: 10 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: newpatchset

Keith Hui (Code Review)

5:45 a.m.

New subject: Change in coreboot[master]: asus/p2b-ls: Replicate OEM GPO configuration

Hello build bot (Jenkins), Paul Menzel, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38354

to look at the new patch set (#11).

Change subject: asus/p2b-ls: Replicate OEM GPO configuration ......................................................................

asus/p2b-ls: Replicate OEM GPO configuration

Replicate the GPO configurations from OEM BIOS, obtained via inteltool. Among the GPOs are termination controls for the onboard SCSI buses.

TEST=read/write Maxtor Atlas 10k3 18GB HDD connected to Ultra2 LVD port

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/38354/11

-- To view, visit https://review.coreboot.org/c/coreboot/+/38354 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86183acd8e1a830d7639c21ec179fbdbe937f8ee Gerrit-Change-Number: 38354 Gerrit-PatchSet: 11 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

23 Apr 23 Apr

10:27 p.m.

New subject: Change in coreboot[master]: asus/p2b-ls: Replicate OEM GPO configuration

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38354 )

Change subject: asus/p2b-ls: Replicate OEM GPO configuration ......................................................................

Patch Set 13:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38354/7/src/mainboard/asus/p2b-ls/d... File src/mainboard/asus/p2b-ls/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/38354/7/src/mainboard/asus/p2b-ls/d... PS7, Line 13: lid_polarity

...

Maybe call it "case_open_polarity" instead?

This seems to have been dropped, so I guess this can be resolved?

-- To view, visit https://review.coreboot.org/c/coreboot/+/38354 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86183acd8e1a830d7639c21ec179fbdbe937f8ee Gerrit-Change-Number: 38354 Gerrit-PatchSet: 13 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Thu, 23 Apr 2020 20:27:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Keith Hui (Code Review)

11:08 p.m.

New subject: Change in coreboot[master]: asus/p2b-ls: Replicate OEM GPO configuration

Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38354 )

Change subject: asus/p2b-ls: Replicate OEM GPO configuration ......................................................................

Patch Set 13:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38354/7/src/mainboard/asus/p2b-ls/d... File src/mainboard/asus/p2b-ls/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/38354/7/src/mainboard/asus/p2b-ls/d... PS7, Line 13: lid_polarity

...

This seems to have been dropped, so I guess this can be resolved?

It was taken out of this patch's scope with the overridetree commit.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38354 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86183acd8e1a830d7639c21ec179fbdbe937f8ee Gerrit-Change-Number: 38354 Gerrit-PatchSet: 13 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Thu, 23 Apr 2020 21:08:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Angel Pons (Code Review)

25 Apr 25 Apr

5:23 p.m.

New subject: Change in coreboot[master]: asus/p2b-ls: Replicate OEM GPO configuration

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38354 )

Change subject: asus/p2b-ls: Replicate OEM GPO configuration ......................................................................

Patch Set 13: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/38354/7/src/mainboard/asus/p2b-ls/d... File src/mainboard/asus/p2b-ls/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/38354/7/src/mainboard/asus/p2b-ls/d... PS7, Line 13: lid_polarity

...

It was taken out of this patch's scope with the overridetree commit.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/38354 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86183acd8e1a830d7639c21ec179fbdbe937f8ee Gerrit-Change-Number: 38354 Gerrit-PatchSet: 13 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Sat, 25 Apr 2020 15:23:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Keith Hui buurin@gmail.com Gerrit-MessageType: comment

Angel Pons (Code Review)

5:24 p.m.

New subject: Change in coreboot[master]: asus/p2b-ls: Replicate OEM GPO configuration

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38354 )

Change subject: asus/p2b-ls: Replicate OEM GPO configuration ......................................................................

asus/p2b-ls: Replicate OEM GPO configuration

Replicate the GPO configurations from OEM BIOS, obtained via inteltool. Among the GPOs are termination controls for the onboard SCSI buses.

TEST=read/write Maxtor Atlas 10k3 18GB HDD connected to Ultra2 LVD port

Change-Id: I86183acd8e1a830d7639c21ec179fbdbe937f8ee Signed-off-by: Keith Hui buurin@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38354 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/asus/p2b/variants/p2b-ls/overridetree.cb 1 file changed, 4 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved

diff --git a/src/mainboard/asus/p2b/variants/p2b-ls/overridetree.cb b/src/mainboard/asus/p2b/variants/p2b-ls/overridetree.cb index bb252c0..541db02 100644 --- a/src/mainboard/asus/p2b/variants/p2b-ls/overridetree.cb +++ b/src/mainboard/asus/p2b/variants/p2b-ls/overridetree.cb @@ -1,6 +1,10 @@ chip northbridge/intel/i440bx # Northbridge device domain 0 on # PCI domain chip southbridge/intel/i82371eb # Southbridge + register "gpo" = "0x7fbfb9ff" + register "gpo22_enable" = "1" # GPO22 controls LVD port termination (0=enabled) + # GPO23 controls SCSI-50 port termination (1=enabled) + # SCSI-68 port is always terminated device pci 4.0 on # ISA bridge chip superio/winbond/w83977tf # Super I/O device pnp 3f0.a off # ACPI

-- To view, visit https://review.coreboot.org/c/coreboot/+/38354 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86183acd8e1a830d7639c21ec179fbdbe937f8ee Gerrit-Change-Number: 38354 Gerrit-PatchSet: 14 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: merged

9elements QA (Code Review)

5:40 p.m.

New subject: Change in coreboot[master]: asus/p2b-ls: Replicate OEM GPO configuration

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38354 )

Change subject: asus/p2b-ls: Replicate OEM GPO configuration ......................................................................

Patch Set 14:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2659 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2658 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2657 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/2656

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/38354 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86183acd8e1a830d7639c21ec179fbdbe937f8ee Gerrit-Change-Number: 38354 Gerrit-PatchSet: 14 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Keith Hui buurin@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Sat, 25 Apr 2020 15:40:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1840

days inactive

1945

days old

coreboot-gerrit@coreboot.org

22 comments

5 participants

tags (0)

participants (5)

9elements QA (Code Review)
Angel Pons (Code Review)
Keith Hui (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)