Attention is currently required from: Jan Philipp Groß, Nicholas Chin, Paul Menzel.
Angel Pons has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/86006?usp=email )
Change subject: mb/asrock/fatal1ty_z87_professional: Update devicetree
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86006/comment/70b31163_efa1a1ae?usp... :
PS3, Line 12: Changes have been tested on the mainboard.
But was the testing successful? :D
I'd suggest testing if the board still boots to OS (I imagine you tested some Linux distro) and suspends/resumes fine. Then you can say something like:
Tested on hardware, no regressions were observed.
Mainboard still boots Linux, and S3 resume works.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86006?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifbbb981cd62a49d112d2bc379f5941819ca70e44
Gerrit-Change-Number: 86006
Gerrit-PatchSet: 3
Gerrit-Owner: Jan Philipp Groß
jeangrande@mailbox.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jan Philipp Groß
jeangrande@mailbox.org
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Comment-Date: Thu, 16 Jan 2025 14:15:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes