Attention is currently required from: Intel coreboot Reviewers, Jayvik Desai, Kapil Porwal, Pranava Y N, Sowmya Aralguppe.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87089?usp=email )
Change subject: soc/intel/pantherlake: Allow board-specific SOC memory config override
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/fatcat/romstage.c:
https://review.coreboot.org/c/coreboot/+/87089/comment/a1bfade1_42c488fc?usp... :
PS1, Line 42: /* default implementation does nothing */
NIT:A printf calling out that its weak function would be helpful ?
i don't think there is any requirement. there are tons of empty weak function w/o printk
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87089?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I403bc4270ef526363defa6cd7d22741ad42a8a76
Gerrit-Change-Number: 87089
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sowmya Aralguppe
sowmya.aralguppe@intel.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Sowmya Aralguppe
sowmya.aralguppe@intel.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Wed, 02 Apr 2025 06:30:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sowmya Aralguppe
sowmya.aralguppe@intel.com