Hello Jason Glenesk,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/45114
to review the following change.
Change subject: vc/amd/fsp/picasso: Add a GUID for reporting NB IOAPIC base ......................................................................
vc/amd/fsp/picasso: Add a GUID for reporting NB IOAPIC base
The GUID will be used in an upcoming patch to identify a HOB.
BUG=b:167421913, b:166519072 TEST=none BRANCH=zork
Signed-off-by: Jason Glenesk jason.glenesk@amd.corp-partner.google.com Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Change-Id: I499e0ef801e4e98a63510a326d1134dd98305238 --- M src/vendorcode/amd/fsp/picasso/FspGuids.h 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/45114/1
diff --git a/src/vendorcode/amd/fsp/picasso/FspGuids.h b/src/vendorcode/amd/fsp/picasso/FspGuids.h index 70bbe74..277fce1 100644 --- a/src/vendorcode/amd/fsp/picasso/FspGuids.h +++ b/src/vendorcode/amd/fsp/picasso/FspGuids.h @@ -33,4 +33,8 @@ GUID_INIT(0xf2784616, 0xb9bf, 0x4e1e, \ 0x99, 0xe0, 0x96, 0x26, 0xda, 0x7e, 0xa5, 0xf5)
+#define AMD_FSP_NB_IOAPIC_BASE_HOB_GUID \ + GUID_INIT(0xdd9738b3, 0x679e, 0x4e19, \ + 0x80, 0xd1, 0xe4, 0x99, 0xed, 0x0a, 0x6d, 0xa1) + #endif /* __FSP_GUIDS__ */
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45114 )
Change subject: vc/amd/fsp/picasso: Add a GUID for reporting NB IOAPIC base ......................................................................
Patch Set 1: Code-Review+2
Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45114 )
Change subject: vc/amd/fsp/picasso: Add a GUID for reporting NB IOAPIC base ......................................................................
Patch Set 1: Code-Review+1
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45114 )
Change subject: vc/amd/fsp/picasso: Add a GUID for reporting NB IOAPIC base ......................................................................
Patch Set 1: Code-Review+2
Marshall Dawson has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45114 )
Change subject: vc/amd/fsp/picasso: Add a GUID for reporting NB IOAPIC base ......................................................................
Abandoned
Changing direction, won't report via a HOB.