Change in coreboot[master]: mb/lenovo/x230: Add support for ThinkLight

List overview All Threads
Download

newer

older

Change in coreboot[master]: src:...

Change in coreboot[master]:...

Stefan Ott (Code Review)

23 Apr 2020 23 Apr '20

6:18 p.m.

Stefan Ott has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40669 )

Change subject: mb/lenovo/x230: Add support for ThinkLight ......................................................................

mb/lenovo/x230: Add support for ThinkLight

With this patch, the ThinkLight on the ThinkPad X230 can be controlled through the OS. This was initially done for the X201 in f63fbdb6: mb/lenovo/x201: Add support for ThinkLight.

After applying this patch, the light can be controlled like this:

echo on >/proc/acpi/ibm/light echo off >/proc/acpi/ibm/light

Or through sysfs at /sys/class/leds/tpacpi::thinklight

Unfortunately I do not own an X230 to test this.

Change-Id: Idd93b26f52eccb8fc79888f1e45117f26d694291 Signed-off-by: Stefan Ott stefan@ott.net --- M src/mainboard/lenovo/x230/dsdt.asl 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/40669/1

diff --git a/src/mainboard/lenovo/x230/dsdt.asl b/src/mainboard/lenovo/x230/dsdt.asl index a03b252..c04195a 100644 --- a/src/mainboard/lenovo/x230/dsdt.asl +++ b/src/mainboard/lenovo/x230/dsdt.asl @@ -37,4 +37,5 @@ }

#include <southbridge/intel/common/acpi/sleepstates.asl> + #include <ec/lenovo/h8/acpi/lightlight.asl> }

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Stefan Ott (Code Review)

23 Apr 23 Apr

7 p.m.

Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40669

to look at the new patch set (#2).

Change subject: mb/lenovo/x230: Add support for ThinkLight ......................................................................

mb/lenovo/x230: Add support for ThinkLight

With this patch, the ThinkLight on the ThinkPad X230 can be controlled through the OS. This was initially done for the X201 in f63fbdb6: mb/lenovo/x201: Add support for ThinkLight.

After applying this patch, the light can be controlled like this:

echo on >/proc/acpi/ibm/light echo off >/proc/acpi/ibm/light

Or through sysfs at /sys/class/leds/tpacpi::thinklight

Unfortunately I do not own an X230 to test this.

Change-Id: Idd93b26f52eccb8fc79888f1e45117f26d694291 Signed-off-by: Stefan Ott stefan@ott.net --- M src/mainboard/lenovo/x230/dsdt.asl 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/40669/2

Angel Pons (Code Review)

11:52 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40669 )

Change subject: mb/lenovo/x230: Add support for ThinkLight ......................................................................

Patch Set 2: Code-Review+1

Waiting for test...

-- To view, visit https://review.coreboot.org/c/coreboot/+/40669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd93b26f52eccb8fc79888f1e45117f26d694291 Gerrit-Change-Number: 40669 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 23 Apr 2020 21:52:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

24 Apr 24 Apr

2:38 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40669 )

Change subject: mb/lenovo/x230: Add support for ThinkLight ......................................................................

Patch Set 2:

Martin, it’d be great if you tested this.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd93b26f52eccb8fc79888f1e45117f26d694291 Gerrit-Change-Number: 40669 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Kepplinger martink@posteo.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 24 Apr 2020 12:38:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Alexander Couzens (Code Review)

21 May 21 May

3:59 a.m.

Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40669 )

Change subject: mb/lenovo/x230: Add support for ThinkLight ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd93b26f52eccb8fc79888f1e45117f26d694291 Gerrit-Change-Number: 40669 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Kepplinger martink@posteo.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 21 May 2020 01:59:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Alexander Couzens (Code Review)

3:59 a.m.

Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40669 )

Change subject: mb/lenovo/x230: Add support for ThinkLight ......................................................................

Patch Set 3: Code-Review-2

LGTM and tested on a x230. I would like to merge this after the x230 is a variant.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd93b26f52eccb8fc79888f1e45117f26d694291 Gerrit-Change-Number: 40669 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Kepplinger martink@posteo.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 21 May 2020 01:59:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Alexander Couzens (Code Review)

5:13 a.m.

Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40669 )

Change subject: mb/lenovo/x230: Add support for ThinkLight ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd93b26f52eccb8fc79888f1e45117f26d694291 Gerrit-Change-Number: 40669 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Kepplinger martink@posteo.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 21 May 2020 03:13:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Alexander Couzens (Code Review)

5:14 a.m.

Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40669 )

Change subject: mb/lenovo/x230: Add support for ThinkLight ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40669/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40669/3//COMMIT_MSG@20 PS3, Line 20: Unfortunately I do not own an X230 to test this. Can you remove this line and add "Tested-by: Alexander Couzens lynxis@fe80.eu"

-- To view, visit https://review.coreboot.org/c/coreboot/+/40669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd93b26f52eccb8fc79888f1e45117f26d694291 Gerrit-Change-Number: 40669 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Kepplinger martink@posteo.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 21 May 2020 03:14:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

2 Jun 2 Jun

9:44 a.m.

Patrick Georgi has uploaded a new patch set (#4) to the change originally created by Stefan Ott. ( https://review.coreboot.org/c/coreboot/+/40669 )

Change subject: mb/lenovo/x230: Add support for ThinkLight ......................................................................

mb/lenovo/x230: Add support for ThinkLight

With this patch, the ThinkLight on the ThinkPad X230 can be controlled through the OS. This was initially done for the X201 in f63fbdb6: mb/lenovo/x201: Add support for ThinkLight.

After applying this patch, the light can be controlled like this:

echo on >/proc/acpi/ibm/light echo off >/proc/acpi/ibm/light

Or through sysfs at /sys/class/leds/tpacpi::thinklight

Change-Id: Idd93b26f52eccb8fc79888f1e45117f26d694291 Signed-off-by: Stefan Ott stefan@ott.net Tested-by: Alexander Couzens lynxis@fe80.eu --- M src/mainboard/lenovo/x230/dsdt.asl 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/40669/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/40669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd93b26f52eccb8fc79888f1e45117f26d694291 Gerrit-Change-Number: 40669 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Kepplinger martink@posteo.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

9:45 a.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40669 )

Change subject: mb/lenovo/x230: Add support for ThinkLight ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40669/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40669/3//COMMIT_MSG@20 PS3, Line 20: Unfortunately I do not own an X230 to test this.

...

Can you remove this line and add […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/40669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd93b26f52eccb8fc79888f1e45117f26d694291 Gerrit-Change-Number: 40669 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Kepplinger martink@posteo.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 02 Jun 2020 07:45:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Alexander Couzens lynxis@fe80.eu Gerrit-MessageType: comment

Patrick Georgi (Code Review)

9:45 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40669 )

Change subject: mb/lenovo/x230: Add support for ThinkLight ......................................................................

mb/lenovo/x230: Add support for ThinkLight

With this patch, the ThinkLight on the ThinkPad X230 can be controlled through the OS. This was initially done for the X201 in f63fbdb6: mb/lenovo/x201: Add support for ThinkLight.

After applying this patch, the light can be controlled like this:

echo on >/proc/acpi/ibm/light echo off >/proc/acpi/ibm/light

Or through sysfs at /sys/class/leds/tpacpi::thinklight

Change-Id: Idd93b26f52eccb8fc79888f1e45117f26d694291 Signed-off-by: Stefan Ott stefan@ott.net Tested-by: Alexander Couzens lynxis@fe80.eu Reviewed-on: https://review.coreboot.org/c/coreboot/+/40669 Reviewed-by: Alexander Couzens lynxis@fe80.eu Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/lenovo/x230/dsdt.asl 1 file changed, 1 insertion(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Alexander Couzens: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve

diff --git a/src/mainboard/lenovo/x230/dsdt.asl b/src/mainboard/lenovo/x230/dsdt.asl index f0964d3..b83fe38 100644 --- a/src/mainboard/lenovo/x230/dsdt.asl +++ b/src/mainboard/lenovo/x230/dsdt.asl @@ -35,4 +35,5 @@ }

#include <southbridge/intel/common/acpi/sleepstates.asl> + #include <ec/lenovo/h8/acpi/thinklight.asl> }

-- To view, visit https://review.coreboot.org/c/coreboot/+/40669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd93b26f52eccb8fc79888f1e45117f26d694291 Gerrit-Change-Number: 40669 Gerrit-PatchSet: 5 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Kepplinger martink@posteo.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

9elements QA (Code Review)

1:34 p.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40669 )

Change subject: mb/lenovo/x230: Add support for ThinkLight ......................................................................

Patch Set 5:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4628 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4627 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4626 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4625

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/40669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd93b26f52eccb8fc79888f1e45117f26d694291 Gerrit-Change-Number: 40669 Gerrit-PatchSet: 5 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Kepplinger martink@posteo.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 02 Jun 2020 11:34:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1635

days inactive

1675

days old

coreboot-gerrit@coreboot.org

11 comments

6 participants

tags (0)

participants (6)

9elements QA (Code Review)
Alexander Couzens (Code Review)
Angel Pons (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)
Stefan Ott (Code Review)