Attention is currently required from: Ivy Jian, Angel Pons, Nick Vaccaro.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62384 )
Change subject: mb/google/brya/var/agah: Add GPU power sequencing
......................................................................
Patch Set 7:
(2 comments)
File src/mainboard/google/brya/variants/agah/variant.c:
https://review.coreboot.org/c/coreboot/+/62384/comment/9c764039_3bb5c347
PS6, Line 47:
Why is this a tab?
oops
https://review.coreboot.org/c/coreboot/+/62384/comment/e5374d34_9034ac17
PS6, Line 119: gpu_powered_on = dgpu_power_sequence_on() == CB_SUCCESS;
`dgpu_power_sequence_on()` already sets `gpu_powered_on`
d'oh! fixed
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62384
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1072be12ef58af5859e2a2d19c4a9c1adc0b0f88
Gerrit-Change-Number: 62384
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Wed, 04 May 2022 18:50:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment