HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41787 )
Change subject: soc/intel/quark/memmap: Add missing 'include <cpu/x86/mtrr.h>' ......................................................................
soc/intel/quark/memmap: Add missing 'include <cpu/x86/mtrr.h>'
Change-Id: I6a066659758aeb0251d9b37f525ad987b90832db Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/intel/quark/memmap.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/41787/1
diff --git a/src/soc/intel/quark/memmap.c b/src/soc/intel/quark/memmap.c index c2a2b5d..97a9fd8 100644 --- a/src/soc/intel/quark/memmap.c +++ b/src/soc/intel/quark/memmap.c @@ -2,6 +2,7 @@
#include <arch/romstage.h> #include <cbmem.h> +#include <cpu/x86/mtrr.h> #include <soc/reg_access.h>
void fill_postcar_frame(struct postcar_frame *pcf)
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41787 )
Change subject: soc/intel/quark/memmap: Add missing 'include <cpu/x86/mtrr.h>' ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41787 )
Change subject: soc/intel/quark/memmap: Add missing 'include <cpu/x86/mtrr.h>' ......................................................................
soc/intel/quark/memmap: Add missing 'include <cpu/x86/mtrr.h>'
Change-Id: I6a066659758aeb0251d9b37f525ad987b90832db Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/41787 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/quark/memmap.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/quark/memmap.c b/src/soc/intel/quark/memmap.c index c2a2b5d..97a9fd8 100644 --- a/src/soc/intel/quark/memmap.c +++ b/src/soc/intel/quark/memmap.c @@ -2,6 +2,7 @@
#include <arch/romstage.h> #include <cbmem.h> +#include <cpu/x86/mtrr.h> #include <soc/reg_access.h>
void fill_postcar_frame(struct postcar_frame *pcf)
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41787 )
Change subject: soc/intel/quark/memmap: Add missing 'include <cpu/x86/mtrr.h>' ......................................................................
Patch Set 5:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4823 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4822 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4821 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4820
Please note: This test is under development and might not be accurate at all!