Change in coreboot[master]: trogdor: Assert EN_PP3300_HUB

[Julius Werner (Code Review)]

Hello Matthias Kaehlcke, Philip Chen, mturney mturney,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/44744

to review the following change.

Change subject: trogdor: Assert EN_PP3300_HUB
......................................................................

trogdor: Assert EN_PP3300_HUB

Some Trogdor variants power their USB hub from a PMIC LDO that is
already enabled by QcLib, and some have a discrete LDO that is
controlled by GPIO_84. For the latter, let's make sure we assert that
GPIO on boot.

Signed-off-by: Julius Werner 
Change-Id: I9d206cd7154ded3bf179e68c2b1421d0a8ee89f2
---
M src/mainboard/google/trogdor/mainboard.c
1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/44744/1

diff --git a/src/mainboard/google/trogdor/mainboard.c b/src/mainboard/google/trogdor/mainboard.c
index c82eaa0..4d6e352 100644
--- a/src/mainboard/google/trogdor/mainboard.c
+++ b/src/mainboard/google/trogdor/mainboard.c
@@ -12,6 +12,9 @@

static void setup_usb(void)
 {
+	/* Assert EN_PP3300_HUB for those board variants that use it. */
+	gpio_output(GPIO(84), 1);
+
    setup_usb_host0(&usb0_board_data);
 }

[mturney mturney (Code Review)]

mturney mturney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44744 )

Change subject: trogdor: Assert EN_PP3300_HUB
......................................................................

Patch Set 1: Code-Review+1

[Matthias Kaehlcke (Code Review)]

Matthias Kaehlcke has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44744 )

Change subject: trogdor: Assert EN_PP3300_HUB
......................................................................

Patch Set 1: Code-Review+1

[Philip Chen (Code Review)]

Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44744 )

Change subject: trogdor: Assert EN_PP3300_HUB
......................................................................

Patch Set 1: Code-Review+2

[Julius Werner (Code Review)]

Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44744 )

Change subject: trogdor: Assert EN_PP3300_HUB
......................................................................

trogdor: Assert EN_PP3300_HUB

Some Trogdor variants power their USB hub from a PMIC LDO that is
already enabled by QcLib, and some have a discrete LDO that is
controlled by GPIO_84. For the latter, let's make sure we assert that
GPIO on boot.

Signed-off-by: Julius Werner 
Change-Id: I9d206cd7154ded3bf179e68c2b1421d0a8ee89f2
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44744
Tested-by: build bot (Jenkins) 
Reviewed-by: mturney mturney 
Reviewed-by: Matthias Kaehlcke 
Reviewed-by: Philip Chen 
---
M src/mainboard/google/trogdor/mainboard.c
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Philip Chen: Looks good to me, approved
  Matthias Kaehlcke: Looks good to me, but someone else must approve
  mturney mturney: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/trogdor/mainboard.c b/src/mainboard/google/trogdor/mainboard.c
index c82eaa0..4d6e352 100644
--- a/src/mainboard/google/trogdor/mainboard.c
+++ b/src/mainboard/google/trogdor/mainboard.c
@@ -12,6 +12,9 @@

static void setup_usb(void)
 {
+	/* Assert EN_PP3300_HUB for those board variants that use it. */
+	gpio_output(GPIO(84), 1);
+
    setup_usb_host0(&usb0_board_data);
 }