Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41704 )
Change subject: [WIP] mb/purism/librem: Add dummy EC driver ......................................................................
[WIP] mb/purism/librem: Add dummy EC driver
Follow-up changes for static devicetree generation remove empty weak chip_operations declaration. Provide empty stub.
Change-Id: I156f38419bd3a3192c919045220062227eca5e7d Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- A src/ec/purism/librem/Makefile.inc A src/ec/purism/librem/ec.c M src/mainboard/purism/librem_skl/Kconfig 3 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/41704/1
diff --git a/src/ec/purism/librem/Makefile.inc b/src/ec/purism/librem/Makefile.inc new file mode 100644 index 0000000..cf0fdf3 --- /dev/null +++ b/src/ec/purism/librem/Makefile.inc @@ -0,0 +1,3 @@ +## SPDX-License-Identifier: GPL-2.0-only + +ramstage-$(CONFIG_EC_PURISM_LIBREM) += ec.c diff --git a/src/ec/purism/librem/ec.c b/src/ec/purism/librem/ec.c new file mode 100644 index 0000000..c129616 --- /dev/null +++ b/src/ec/purism/librem/ec.c @@ -0,0 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <device/device.h> + +struct chip_operations ec_purism_librem_ops = { + CHIP_NAME("PURISM LIBREM EC") +}; diff --git a/src/mainboard/purism/librem_skl/Kconfig b/src/mainboard/purism/librem_skl/Kconfig index c86ebf1..58921f2 100644 --- a/src/mainboard/purism/librem_skl/Kconfig +++ b/src/mainboard/purism/librem_skl/Kconfig @@ -2,6 +2,7 @@ def_bool n select BOARD_ROMSIZE_KB_16384 select DRIVERS_GENERIC_CBFS_SERIAL + select EC_PURISM_LIBREM select GFX_GMA_IGNORE_PRESENCE_STRAPS select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41704 )
Change subject: [WIP] mb/purism/librem: Add dummy EC driver ......................................................................
Patch Set 1:
I think my preference for this would be to simply drop the devicetree entry (same as librem_bdw) since they're both using the same EC, and I can't see adding any C code to the EC in the future.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41704 )
Change subject: [WIP] mb/purism/librem: Add dummy EC driver ......................................................................
Patch Set 2:
Patch Set 1:
I think my preference for this would be to simply drop the devicetree entry (same as librem_bdw) since they're both using the same EC, and I can't see adding any C code to the EC in the future.
Matt, can you push the change you want? I am also wondering if IO address 0xc09 for EC was correct at all, and if LPC routing gets messed up if we remove the devicetree entry.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41704 )
Change subject: [WIP] mb/purism/librem: Add dummy EC driver ......................................................................
Patch Set 2: Code-Review+1
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41704 )
Change subject: [WIP] mb/purism/librem: Add dummy EC driver ......................................................................
Patch Set 2:
Patch Set 2:
Matt, can you push the change you want? I am also wondering if IO address 0xc09 for EC was correct at all, and if LPC routing gets messed up if we remove the devicetree entry.
CB:41788
Almost positive the IO address was just a copy-pasta from a Google board and not actually correct
Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41704 )
Change subject: [WIP] mb/purism/librem: Add dummy EC driver ......................................................................
Abandoned
took different approach
-
Angel Pons (Code Review) -
Kyösti Mälkki (Code Review)
-
Matt DeVillier (Code Review)