Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47892 )
Change subject: mb/system76/oryp5: Add System76 Oryx Pro 5 ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47892/5/Documentation/mainboard/sys... File Documentation/mainboard/system76/oryp5.md:
https://review.coreboot.org/c/coreboot/+/47892/5/Documentation/mainboard/sys... PS5, Line 12: - eDP 16.1" or 17.3" 1920x1080 @ 144 Hz LCD
I will have to rebase and check. (They worked on Linux, which was good enough for me. […]
I suspect the backlight is currently controlled through i915's own backlight interface in sysfs.
https://review.coreboot.org/c/coreboot/+/47892/5/src/mainboard/system76/oryp... File src/mainboard/system76/oryp5/gpio.c:
https://review.coreboot.org/c/coreboot/+/47892/5/src/mainboard/system76/oryp... PS5, Line 98: PAD_NC(GPP_C20, UP_20K), // UART2_RXD (test point) : PAD_NC(GPP_C21, UP_20K), // UART2_TXD (test point)
Changing these back to NF. Should I move them to early_gpio. […]
Yes please, for the sake of completeness
https://review.coreboot.org/c/coreboot/+/47892/5/src/mainboard/system76/oryp... File src/mainboard/system76/oryp5/romstage.c:
https://review.coreboot.org/c/coreboot/+/47892/5/src/mainboard/system76/oryp... PS5, Line 25: 0
What do you mean by synchronized? […]
Ideally, this would be set in SoC code depending on ONBOARD_VGA_IS_PRIMARY.
-
Angel Pons (Code Review)