Change in coreboot[master]: mb/google/hatch: Add settings for noise mitgation

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in coreboot[master]: arm64:...

Dtrain Hsu (Code Review)

20 Aug 2019 20 Aug '19

7:52 a.m.

Dtrain Hsu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35005 )

Change subject: mb/google/hatch: Add settings for noise mitgation ......................................................................

mb/google/hatch: Add settings for noise mitgation

Enable acoustic noise mitgation for hatch platform, the slow slew rates are fast time dived by 8 and disable Fast PKG C State Ramp(IA, GT, SA).

BUG=b:131779678 TEST=waveform test and reduce the noise level.

Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Change-Id: I49e834825b3f1e5bf02f9523d7caa93b544c9d17 --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/35005/1

diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index c87a8bc..62cb3ca 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -193,6 +193,15 @@ # register "common_soc_config.<variable_name>" = "value" register "common_soc_config.chipset_lockdown" = CHIPSET_LOCKDOWN_COREBOOT

+ # VR Slew rate setting + register "AcousticNoiseMitigation" = "1" + register "SlowSlewRateForIa" = "2" + register "SlowSlewRateForGt" = "2" + register "SlowSlewRateForSa" = "2" + register "FastPkgCRampDisableIa" = "1" + register "FastPkgCRampDisableGt" = "1" + register "FastPkgCRampDisableSa" = "1" + device cpu_cluster 0 on device lapic 0 on end end

Attachments:

attachment.htm (text/html — 3.5 KB)

Show replies by date

Furquan Shaikh (Code Review)

20 Aug 20 Aug

7:56 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35005 )

Change subject: mb/google/hatch: Add settings for noise mitgation ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35005/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/35005/1/src/mainboard/google/hatch/... PS1, Line 196: # VR Slew rate setting : register "AcousticNoiseMitigation" = "1" : register "SlowSlewRateForIa" = "2" : register "SlowSlewRateForGt" = "2" : register "SlowSlewRateForSa" = "2" : register "FastPkgCRampDisableIa" = "1" : register "FastPkgCRampDisableGt" = "1" : register "FastPkgCRampDisableSa" = "1" I believe these are currently required only for hatch variant. So, it would be good to add these to hatch/overridetree.cb

Dtrain Hsu (Code Review)

8:09 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35005

to look at the new patch set (#2).

Change subject: mb/google/hatch: Add settings for noise mitgation ......................................................................

mb/google/hatch: Add settings for noise mitgation

Enable acoustic noise mitgation for hatch platform, the slow slew rates are fast time dived by 8 and disable Fast PKG C State Ramp(IA, GT, SA).

BUG=b:131779678 TEST=waveform test and reduce the noise level.

Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Change-Id: I49e834825b3f1e5bf02f9523d7caa93b544c9d17 --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb 1 file changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/35005/2

Dtrain Hsu (Code Review)

8:21 a.m.

Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35005 )

Change subject: mb/google/hatch: Add settings for noise mitgation ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35005/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:

...

I believe these are currently required only for hatch variant. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/35005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49e834825b3f1e5bf02f9523d7caa93b544c9d17 Gerrit-Change-Number: 35005 Gerrit-PatchSet: 2 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: John Su john_su@compal.corp-partner.google.com Gerrit-Comment-Date: Tue, 20 Aug 2019 06:21:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Subrata Banik (Code Review)

26 Aug 26 Aug

5:32 p.m.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35005 )

Change subject: mb/google/hatch: Add settings for noise mitgation ......................................................................

Patch Set 2:

what kind of test do we run to conclude on these particular values ?

-- To view, visit https://review.coreboot.org/c/coreboot/+/35005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49e834825b3f1e5bf02f9523d7caa93b544c9d17 Gerrit-Change-Number: 35005 Gerrit-PatchSet: 2 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Balaji Manigandan balaji.manigandan@intel.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: John Su john_su@compal.corp-partner.google.com Gerrit-Comment-Date: Mon, 26 Aug 2019 15:32:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kane Chen (Code Review)

27 Aug 27 Aug

5:40 a.m.

Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35005 )

Change subject: mb/google/hatch: Add settings for noise mitgation ......................................................................

Patch Set 2:

Hi What issue did you observe? Did you hear the noise? or any measurement shows the issue?

-- To view, visit https://review.coreboot.org/c/coreboot/+/35005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49e834825b3f1e5bf02f9523d7caa93b544c9d17 Gerrit-Change-Number: 35005 Gerrit-PatchSet: 2 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Balaji Manigandan balaji.manigandan@intel.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: John Su john_su@compal.corp-partner.google.com Gerrit-CC: Kane Chen kane.chen@intel.corp-partner.google.com Gerrit-Comment-Date: Tue, 27 Aug 2019 03:40:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Joe_Wang (Code Review)

29 Aug 29 Aug

3:45 a.m.

Joe_Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35005 )

Change subject: mb/google/hatch: Add settings for noise mitgation ......................................................................

Patch Set 2:

...

Patch Set 2:

what kind of test do we run to conclude on these particular values ?

(Acoustic)Audible EE noise test in Compal shows that 1/8 slew rate can reduce the noise level.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49e834825b3f1e5bf02f9523d7caa93b544c9d17 Gerrit-Change-Number: 35005 Gerrit-PatchSet: 2 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Balaji Manigandan balaji.manigandan@intel.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Joe_Wang Gerrit-CC: John Su john_su@compal.corp-partner.google.com Gerrit-CC: Kane Chen kane.chen@intel.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 29 Aug 2019 01:45:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Joe_Wang (Code Review)

3:47 a.m.

Joe_Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35005 )

Change subject: mb/google/hatch: Add settings for noise mitgation ......................................................................

Patch Set 2:

...

Patch Set 2:

Hi What issue did you observe? Did you hear the noise? or any measurement shows the issue?

Google RD found audible noise on PCBA, and Compal acoustic test results showed it got improved when rework MLCC and change to 1/8 slew rate.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49e834825b3f1e5bf02f9523d7caa93b544c9d17 Gerrit-Change-Number: 35005 Gerrit-PatchSet: 2 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Balaji Manigandan balaji.manigandan@intel.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Joe_Wang Gerrit-CC: John Su john_su@compal.corp-partner.google.com Gerrit-CC: Kane Chen kane.chen@intel.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 29 Aug 2019 01:47:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

4:39 a.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35005 )

Change subject: mb/google/hatch: Add settings for noise mitgation ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49e834825b3f1e5bf02f9523d7caa93b544c9d17 Gerrit-Change-Number: 35005 Gerrit-PatchSet: 2 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Balaji Manigandan balaji.manigandan@intel.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Joe_Wang Gerrit-CC: John Su john_su@compal.corp-partner.google.com Gerrit-CC: Kane Chen kane.chen@intel.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 29 Aug 2019 02:39:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

30 Aug 30 Aug

12:37 p.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/35005 )

Change subject: mb/google/hatch: Add settings for noise mitgation ......................................................................

mb/google/hatch: Add settings for noise mitgation

Enable acoustic noise mitgation for hatch platform, the slow slew rates are fast time dived by 8 and disable Fast PKG C State Ramp(IA, GT, SA).

BUG=b:131779678 TEST=waveform test and reduce the noise level.

Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Change-Id: I49e834825b3f1e5bf02f9523d7caa93b544c9d17 Reviewed-on: https://review.coreboot.org/c/coreboot/+/35005 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb 1 file changed, 9 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/hatch/overridetree.cb b/src/mainboard/google/hatch/variants/hatch/overridetree.cb index 880d19f..6ed25c8 100644 --- a/src/mainboard/google/hatch/variants/hatch/overridetree.cb +++ b/src/mainboard/google/hatch/variants/hatch/overridetree.cb @@ -15,6 +15,15 @@ [PchSerialIoIndexUART2] = PchSerialIoDisabled, }"

-- To view, visit https://review.coreboot.org/c/coreboot/+/35005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49e834825b3f1e5bf02f9523d7caa93b544c9d17 Gerrit-Change-Number: 35005 Gerrit-PatchSet: 3 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Balaji Manigandan balaji.manigandan@intel.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Joe_Wang Gerrit-CC: John Su john_su@compal.corp-partner.google.com Gerrit-CC: Kane Chen kane.chen@intel.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

2071

days inactive

2081

days old

coreboot-gerrit@coreboot.org

9 comments

7 participants

tags (0)

participants (7)

Dtrain Hsu (Code Review)
Furquan Shaikh (Code Review)
Joe_Wang (Code Review)
Kane Chen (Code Review)
Patrick Georgi (Code Review)
Subrata Banik (Code Review)
Tim Wawrzynczak (Code Review)