Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/29672 )
Change subject: ec/google/wilco: Enable COM1 ACPI device ......................................................................
ec/google/wilco: Enable COM1 ACPI device
Enable the COM1 ACPI device based on the existing Kconfig option CONFIG_DRIVERS_UART_8250IO instead of expecting the mainboard to also define another value for ACPI.
Change-Id: I69361cc2c245cfcad3e4f57567bf56d5a26f0b06 Signed-off-by: Duncan Laurie dlaurie@google.com Reviewed-on: https://review.coreboot.org/c/29672 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/ec/google/wilco/acpi/superio.asl 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/ec/google/wilco/acpi/superio.asl b/src/ec/google/wilco/acpi/superio.asl index a8cea78..9c23c49 100644 --- a/src/ec/google/wilco/acpi/superio.asl +++ b/src/ec/google/wilco/acpi/superio.asl @@ -29,7 +29,7 @@
Method (_STA, 0, NotSerialized) { -#ifdef SIO_EC_ENABLE_COM1 +#if IS_ENABLED(CONFIG_DRIVERS_UART_8250IO) Return (0x0f) #else Return (Zero)