Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27277 )
Change subject: soc/amd/common: Fix AmdLateRunApTask() ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/27277/5/src/soc/amd/common/block/pi/agesawra... File src/soc/amd/common/block/pi/agesawrapper.c:
https://review.coreboot.org/#/c/27277/5/src/soc/amd/common/block/pi/agesawra... PS5, Line 356: amd_late_run_ap_task Just for compatibility with the remaining functions within agesawrapper, even though it's not called by AmdAgesaCallout), I believe this function should be called agesawrapper_amd_late_run_ap_task.
https://review.coreboot.org/#/c/27277/5/src/soc/amd/common/block/pi/def_call... File src/soc/amd/common/block/pi/def_callouts.c:
https://review.coreboot.org/#/c/27277/5/src/soc/amd/common/block/pi/def_call... PS5, Line 208: amd_late_run_ap_task agesawrapper_amd_late_run_ap_task?
-
Richard Spiegel (Code Review)