Attention is currently required from: Nico Huber, Angel Pons, Michael Niewöhner, Werner Zeh. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49542 )
Change subject: [RFC] Documentation/coding_style: Clarify line limit for text blocks ......................................................................
Patch Set 1:
(1 comment)
File Documentation/coding_style.md:
https://review.coreboot.org/c/coreboot/+/49542/comment/135d23af_20e52e8d PS1, Line 97: the overall line length should not exceed 96 chars.
I also can't understand how that makes anything more complicated, for me it's the exact opposite. We use 72 chars in emails, in commit messages, why make an exception for code comments? Just because editors are dull and coders lazy?
Kind of, yeah. Emails are easy because most programs (editors, mailers, review software, etc.) can be programmed to automatically break or at least show a border after X characters. I don't know of anything that supports this kind of "characters after indent" thing you want here. And I think in practice that means barely anyone will do it, barely any reviewer will check it, checkpatch isn't gonna find it, and so this rule would just end up adding more confusion and inconsistency.
I do a lot more reviewing than coding for this project and I am certainly not going to start counting characters on everyone's patches by hand because Gerrit has no way to make something like this clearly visible. I can't imagine anyone else will, either. At some point reviewer/coder convenience absolutely does become a factor that needs to be weighed against the others. And I don't think we should have a situation where basically nobody ever cares about this except for that one time when someone randomly happens to point it out in your CL and then that paragraph in that patch has to be adjusted while everything else is still line length wild west.