Alex Thiessen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30414 )
Change subject: mainboard/facebook/fbg1701: Do initial mainboard commit ......................................................................
Patch Set 23:
(4 comments)
https://review.coreboot.org/#/c/30414/23//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30414/23//COMMIT_MSG@12 PS23, Line 12: manufacture manufacturer
https://review.coreboot.org/#/c/30414/23/src/mainboard/facebook/fbg1701/cmos... File src/mainboard/facebook/fbg1701/cmos.layout:
https://review.coreboot.org/#/c/30414/23/src/mainboard/facebook/fbg1701/cmos... PS23, Line 69: 4 Overflows quickly, please state in a comment when it's OK.
https://review.coreboot.org/#/c/30414/23/src/mainboard/facebook/fbg1701/cmos... PS23, Line 91: 896 32 r 0 mrc_scrambler_seed : 928 32 r 0 mrc_scrambler_seed_s3 Not check-summed, state in a comment when it's by design or adjust the range.
https://review.coreboot.org/#/c/30414/23/src/mainboard/facebook/fbg1701/roms... File src/mainboard/facebook/fbg1701/romstage.c:
https://review.coreboot.org/#/c/30414/23/src/mainboard/facebook/fbg1701/roms... PS23, Line 45: uintptr_t possibly missing direct include
-
Alex Thiessen (Code Review)