Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39183 )
Change subject: util/kconfig: Silence warning about _GNU_SOURCE ......................................................................
util/kconfig: Silence warning about _GNU_SOURCE
For some reason, this symbol gets redefined, which causes a warning. Hide the warning by checking whether it is already defined.
Change-Id: I70ffc9a799e0b536d6aba7d00f828bd6d915d94c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M util/kconfig/nconf.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/39183/1
diff --git a/util/kconfig/nconf.c b/util/kconfig/nconf.c index 905dcd1..42ea494 100644 --- a/util/kconfig/nconf.c +++ b/util/kconfig/nconf.c @@ -5,7 +5,9 @@ * Derived from menuconfig. * */ +#ifndef _GNU_SOURCE #define _GNU_SOURCE +#endif #include <string.h> #include <stdlib.h>
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39183 )
Change subject: util/kconfig: Silence warning about _GNU_SOURCE ......................................................................
Patch Set 1:
_GNU_SOURCE is defined on the command line, probably from some pkgconfig thing. What is the exact warning? There are more places where it's defined like this, should they be adapted as well?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39183 )
Change subject: util/kconfig: Silence warning about _GNU_SOURCE ......................................................................
Patch Set 1:
Patch Set 1:
_GNU_SOURCE is defined on the command line, probably from some pkgconfig thing. What is the exact warning? There are more places where it's defined like this, should they be adapted as well?
It is indeed defined on the command line:
$ make nconfig /home/usuario/coreboot/util/kconfig/nconf.c:8: warning: "_GNU_SOURCE" redefined 8 | #define _GNU_SOURCE | <command-line>: note: this is the location of the previous definition
This is the only file on which I get a warning.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39183 )
Change subject: util/kconfig: Silence warning about _GNU_SOURCE ......................................................................
Patch Set 1:
There's another one in `regex.c` please adapt both at once.
Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39183
to look at the new patch set (#2).
Change subject: util/kconfig: Silence warning about _GNU_SOURCE ......................................................................
util/kconfig: Silence warning about _GNU_SOURCE
For some reason, this symbol gets redefined, which causes a warning. Hide the warning by checking whether it is already defined.
Change-Id: I70ffc9a799e0b536d6aba7d00f828bd6d915d94c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M util/kconfig/nconf.c M util/kconfig/regex.c 2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/39183/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39183 )
Change subject: util/kconfig: Silence warning about _GNU_SOURCE ......................................................................
Patch Set 2:
Patch Set 1:
There's another one in `regex.c` please adapt both at once.
Sure, done
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39183 )
Change subject: util/kconfig: Silence warning about _GNU_SOURCE ......................................................................
Patch Set 2: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39183 )
Change subject: util/kconfig: Silence warning about _GNU_SOURCE ......................................................................
util/kconfig: Silence warning about _GNU_SOURCE
For some reason, this symbol gets redefined, which causes a warning. Hide the warning by checking whether it is already defined.
Change-Id: I70ffc9a799e0b536d6aba7d00f828bd6d915d94c Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39183 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M util/kconfig/nconf.c M util/kconfig/regex.c 2 files changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/util/kconfig/nconf.c b/util/kconfig/nconf.c index 905dcd1..42ea494 100644 --- a/util/kconfig/nconf.c +++ b/util/kconfig/nconf.c @@ -5,7 +5,9 @@ * Derived from menuconfig. * */ +#ifndef _GNU_SOURCE #define _GNU_SOURCE +#endif #include <string.h> #include <stdlib.h>
diff --git a/util/kconfig/regex.c b/util/kconfig/regex.c index a6d947f..d0e1d7b 100644 --- a/util/kconfig/regex.c +++ b/util/kconfig/regex.c @@ -24,7 +24,9 @@ #pragma alloca #endif
+#ifndef _GNU_SOURCE #define _GNU_SOURCE +#endif
/* We need this for `regex.h', and perhaps for the Emacs include files. */ #include <sys/types.h>
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39183 )
Change subject: util/kconfig: Silence warning about _GNU_SOURCE ......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1202 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1201 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1200
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Nico Huber (Code Review)