Eric Lai has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74693 )
Change subject: mb/google/brya/variants/hades: Correct and swap NV33 signals ......................................................................
mb/google/brya/variants/hades: Correct and swap NV33 signals
The signals for the NV33 regulator were swapped (enable and power good). Switch these back to the way they should be:
GPIO_NV33_PWR_EN GPP_E1 GPIO_NV33_PG GPP_E2
BUG=b:269371363 TEST=builds Signed-off-by: Tarun Tuli taruntuli@google.com
Change-Id: Ic2a53103e1feadd7ecebd4bed02dcc34410b8e3b Reviewed-on: https://review.coreboot.org/c/coreboot/+/74693 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Eric Lai eric_lai@quanta.corp-partner.google.com Reviewed-by: Nick Vaccaro nvaccaro@google.com Reviewed-by: Ivy Jian ivy.jian@quanta.corp-partner.google.com --- M src/mainboard/google/brya/acpi/power.asl 1 file changed, 26 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Nick Vaccaro: Looks good to me, approved Eric Lai: Looks good to me, approved Ivy Jian: Looks good to me, approved
diff --git a/src/mainboard/google/brya/acpi/power.asl b/src/mainboard/google/brya/acpi/power.asl index 23759f6..186b109 100644 --- a/src/mainboard/google/brya/acpi/power.asl +++ b/src/mainboard/google/brya/acpi/power.asl @@ -14,8 +14,8 @@ #else #define GPIO_1V8_PWR_EN GPP_E11
-#define GPIO_NV33_PWR_EN GPP_E2 -#define GPIO_NV33_PG GPP_E1 +#define GPIO_NV33_PWR_EN GPP_E1 +#define GPIO_NV33_PG GPP_E2 #endif
#define GPIO_1V8_PG GPP_E20