Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45112 )
Change subject: soc/intel: skl,cnl,icl,jsl,tgl: disable usb over-current pin by default
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45112/2/src/soc/intel/cannonlake/fs...
File src/soc/intel/cannonlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/45112/2/src/soc/intel/cannonlake/fs...
PS2, Line 376: params->Usb2OverCurrentPin[i] = config->usb2_ports[i].ocpin;
Why the indirection when we can have a simple if/else
here? Or can't we?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45112
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib8ea2ea26c0623d4db910e487b37255e907b299d
Gerrit-Change-Number: 45112
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 04 Sep 2020 22:33:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment