Change in coreboot[master]: mb/google/dedede: Create Boten Legacy variant

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Karthik Ramasubramanian (Code Review)

1 Jul 2020 1 Jul '20

6:47 a.m.

Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42961 )

Change subject: mb/google/dedede: Create Boten Legacy variant ......................................................................

mb/google/dedede: Create Boten Legacy variant

Upcoming builds of boten will use 16 MiB SPI ROM. So create a legacy Boten variant to support the builds that use 32 MiB SPI ROM.

BUG=None TEST=Build the boten and boten_legacy variant.

Cq-Depend: TBD Change-Id: Idf7732768aa7fbf2281a4cbf47b7b5b4f8ef51da Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/Kconfig.name 2 files changed, 8 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/42961/1

diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig index 4322520..dcea3fa 100644 --- a/src/mainboard/google/dedede/Kconfig +++ b/src/mainboard/google/dedede/Kconfig @@ -64,6 +64,7 @@ config MAINBOARD_PART_NUMBER string default "Boten" if BOARD_GOOGLE_BOTEN + default "Boten" if BOARD_GOOGLE_BOTEN_LEGACY default "Dedede" if BOARD_GOOGLE_DEDEDE default "Drawcia" if BOARD_GOOGLE_DRAWCIA default "Drawcia" if BOARD_GOOGLE_DRAWCIA_LEGACY @@ -90,6 +91,7 @@ config VARIANT_DIR string default "boten" if BOARD_GOOGLE_BOTEN + default "boten" if BOARD_GOOGLE_BOTEN_LEGACY default "dedede" if BOARD_GOOGLE_DEDEDE default "drawcia" if BOARD_GOOGLE_DRAWCIA default "drawcia" if BOARD_GOOGLE_DRAWCIA_LEGACY diff --git a/src/mainboard/google/dedede/Kconfig.name b/src/mainboard/google/dedede/Kconfig.name index 543675c..5d51f8e 100644 --- a/src/mainboard/google/dedede/Kconfig.name +++ b/src/mainboard/google/dedede/Kconfig.name @@ -3,6 +3,12 @@ select BOARD_GOOGLE_BASEBOARD_DEDEDE select BASEBOARD_DEDEDE_LAPTOP

+config BOARD_GOOGLE_BOTEN_LEGACY + bool "Boten" + select BOARD_GOOGLE_BASEBOARD_DEDEDE + select BASEBOARD_DEDEDE_LAPTOP + select BOARD_ROMSIZE_KB_32768 + config BOARD_GOOGLE_DEDEDE bool "Dedede" select BOARD_GOOGLE_BASEBOARD_DEDEDE

Attachments:

attachment.htm (text/html — 4.2 KB)

Show replies by date

Marco Chen (Code Review)

1 Jul 1 Jul

8:38 a.m.

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42961 )

Change subject: mb/google/dedede: Create Boten Legacy variant ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idf7732768aa7fbf2281a4cbf47b7b5b4f8ef51da Gerrit-Change-Number: 42961 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 01 Jul 2020 08:38:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Marco Chen (Code Review)

8:51 a.m.

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42961 )

Change subject: mb/google/dedede: Create Boten Legacy variant ......................................................................

Patch Set 1: -Code-Review

-- To view, visit https://review.coreboot.org/c/coreboot/+/42961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idf7732768aa7fbf2281a4cbf47b7b5b4f8ef51da Gerrit-Change-Number: 42961 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 01 Jul 2020 08:51:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Marco Chen (Code Review)

8:53 a.m.

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42961 )

Change subject: mb/google/dedede: Create Boten Legacy variant ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42961/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/Kconfig.name:

https://review.coreboot.org/c/coreboot/+/42961/1/src/mainboard/google/dedede... PS1, Line 4: select BASEBOARD_DEDEDE_LAPTOP Similarly I think boten will be used in development of proto so would be with 32M SPI rom before migrating to next HW version?

-- To view, visit https://review.coreboot.org/c/coreboot/+/42961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idf7732768aa7fbf2281a4cbf47b7b5b4f8ef51da Gerrit-Change-Number: 42961 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 01 Jul 2020 08:53:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

5:12 p.m.

Hello build bot (Jenkins), Furquan Shaikh, Henry Sun, Justin TerAvest, Marco Chen,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42961

to look at the new patch set (#2).

Change subject: mb/google/dedede: Create Boten Legacy variant ......................................................................

mb/google/dedede: Create Boten Legacy variant

Upcoming builds of boten will use 16 MiB SPI ROM. So create a legacy Boten variant to support the builds that use 32 MiB SPI ROM.

BUG=None TEST=Build the boten and boten_legacy variant.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/42961/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idf7732768aa7fbf2281a4cbf47b7b5b4f8ef51da Gerrit-Change-Number: 42961 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Karthik Ramasubramanian (Code Review)

5:49 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42961 )

Change subject: mb/google/dedede: Create Boten Legacy variant ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42961/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/Kconfig.name:

https://review.coreboot.org/c/coreboot/+/42961/1/src/mainboard/google/dedede... PS1, Line 4: select BASEBOARD_DEDEDE_LAPTOP

...

Similarly I think boten will be used in development of proto so would be with 32M SPI rom before mig […]

Discussed in the earlier CL in this stack of CLs.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idf7732768aa7fbf2281a4cbf47b7b5b4f8ef51da Gerrit-Change-Number: 42961 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 01 Jul 2020 17:49:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Marco Chen marcochen@google.com Gerrit-MessageType: comment

Justin TerAvest (Code Review)

8:24 p.m.

Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42961 )

Change subject: mb/google/dedede: Create Boten Legacy variant ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idf7732768aa7fbf2281a4cbf47b7b5b4f8ef51da Gerrit-Change-Number: 42961 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 01 Jul 2020 20:24:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

6 Jul 6 Jul

6:11 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42961 )

Change subject: mb/google/dedede: Create Boten Legacy variant ......................................................................

mb/google/dedede: Create Boten Legacy variant

Upcoming builds of boten will use 16 MiB SPI ROM. So create a legacy Boten variant to support the builds that use 32 MiB SPI ROM.

BUG=None TEST=Build the boten and boten_legacy variant.

Cq-Depend: TBD Change-Id: Idf7732768aa7fbf2281a4cbf47b7b5b4f8ef51da Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42961 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Justin TerAvest teravest@chromium.org --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/Kconfig.name 2 files changed, 8 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Justin TerAvest: Looks good to me, approved

diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig index 4322520..dcea3fa 100644 --- a/src/mainboard/google/dedede/Kconfig +++ b/src/mainboard/google/dedede/Kconfig @@ -64,6 +64,7 @@ config MAINBOARD_PART_NUMBER string default "Boten" if BOARD_GOOGLE_BOTEN + default "Boten" if BOARD_GOOGLE_BOTEN_LEGACY default "Dedede" if BOARD_GOOGLE_DEDEDE default "Drawcia" if BOARD_GOOGLE_DRAWCIA default "Drawcia" if BOARD_GOOGLE_DRAWCIA_LEGACY @@ -90,6 +91,7 @@ config VARIANT_DIR string default "boten" if BOARD_GOOGLE_BOTEN + default "boten" if BOARD_GOOGLE_BOTEN_LEGACY default "dedede" if BOARD_GOOGLE_DEDEDE default "drawcia" if BOARD_GOOGLE_DRAWCIA default "drawcia" if BOARD_GOOGLE_DRAWCIA_LEGACY diff --git a/src/mainboard/google/dedede/Kconfig.name b/src/mainboard/google/dedede/Kconfig.name index b74752e..893a457 100644 --- a/src/mainboard/google/dedede/Kconfig.name +++ b/src/mainboard/google/dedede/Kconfig.name @@ -3,6 +3,12 @@ select BOARD_GOOGLE_BASEBOARD_DEDEDE select BASEBOARD_DEDEDE_LAPTOP

+config BOARD_GOOGLE_BOTEN_LEGACY + bool "Boten (Legacy)" + select BOARD_GOOGLE_BASEBOARD_DEDEDE + select BASEBOARD_DEDEDE_LAPTOP + select BOARD_ROMSIZE_KB_32768 + config BOARD_GOOGLE_DEDEDE bool "Dedede" select BOARD_GOOGLE_BASEBOARD_DEDEDE

-- To view, visit https://review.coreboot.org/c/coreboot/+/42961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idf7732768aa7fbf2281a4cbf47b7b5b4f8ef51da Gerrit-Change-Number: 42961 Gerrit-PatchSet: 3 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1548

days inactive

1553

days old

coreboot-gerrit@coreboot.org

7 comments

4 participants

tags (0)

participants (4)

Justin TerAvest (Code Review)
Karthik Ramasubramanian (Code Review)
Marco Chen (Code Review)
Patrick Georgi (Code Review)