Attention is currently required from: Raul Rangel, Martin Roth, Karthik Ramasubramanian. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55149 )
Change subject: mb/google/guybrush: Override I2C3 pad configuration ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/guybrush/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/55149/comment/8908e942_25bc10bc PS1, Line 5: This will have to be done in verstage.c too for PSP on verstage.
File src/mainboard/google/guybrush/i2c.c:
https://review.coreboot.org/c/coreboot/+/55149/comment/f8690157_e51e13ff PS1, Line 8: mainboard_i2c_override What do you think about moving this to a devicetree config? That will eliminate the need for the callback function and also not require mainboard code to manipulate SoC register bits. i.e. drive SoC configuration using controls in device tree.
-
Furquan Shaikh (Code Review)