Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75589?usp=email )
Change subject: lib/dimm_info_util.c: Add newlines to log messages ......................................................................
lib/dimm_info_util.c: Add newlines to log messages
Add newlines to log messages to prevent them from running into each other.
Change-Id: I4f61c80385f384a3734a5122ccb4161c1ed7c6c5 Signed-off-by: Fred Reitberger reitbergerfred@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/75589 Reviewed-by: Elyes Haouas ehaouas@noos.fr Reviewed-by: Felix Singer service+coreboot-gerrit@felixsinger.de Reviewed-by: Felix Held felix-coreboot@felixheld.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/lib/dimm_info_util.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Felix Held: Looks good to me, approved Elyes Haouas: Looks good to me, approved
diff --git a/src/lib/dimm_info_util.c b/src/lib/dimm_info_util.c index 3507366..d16cb46 100644 --- a/src/lib/dimm_info_util.c +++ b/src/lib/dimm_info_util.c @@ -26,7 +26,7 @@ out = MEMORY_BUS_WIDTH_8; break; default: - printk(BIOS_NOTICE, "Unknown memory size %hu", data_width); + printk(BIOS_NOTICE, "Unknown memory size %hu\n", data_width); /* * The SMBIOS spec says we should set 0xFFFF on an unknown * value, but we don't have a way of passing that signal via SPD @@ -49,7 +49,7 @@ /* No extension bits */ break; default: - printk(BIOS_NOTICE, "Unknown number of extension bits %hu", + printk(BIOS_NOTICE, "Unknown number of extension bits %hu\n", extension_bits); break; }