Change in coreboot[master]: mb/google/guybrush/var/guybrush: Add FPMCU configration - coreboot-gerrit

8 Apr 2021


      Attention is currently required from: Furquan Shaikh, Bhanu Prakash Maiya, Ivy Jian.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52181 )
Change subject: mb/google/guybrush/var/guybrush: Add FPMCU configration
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/guybrush/variants/guybrush/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/52181/comment/451c39f2_73370c5c 
PS9, Line 113: register "has_power_resource" = "1"
...
This will not work for FPMCU. We want FPMCU to be kept enabled in S3 and S0i3 states. […]
So, FPMCU need keep alive all the time? In this case, do we only need _PS0 and _PS5 method instead _ON and _OFF?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52181
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c56b0db193be6804d07c2f333445c2a1dbf9f59
Gerrit-Change-Number: 52181
Gerrit-PatchSet: 9
Gerrit-Owner: Ivy Jian ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Bhanu Prakash Maiya bhanumaiya@google.com
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Mathew King mathewk@chromium.org
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Bhanu Prakash Maiya bhanumaiya@google.com
Gerrit-Attention: Ivy Jian ivy_jian@compal.corp-partner.google.com
Gerrit-Comment-Date: Thu, 08 Apr 2021 17:31:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment