Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Eric Lai, Intel coreboot Reviewers, Jakub Czapiga, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Pranava Y N, Sean Rhodes, Subrata Banik, Tarun, Werner Zeh.
Hello Dinesh Gehlot, Eran Mitrani, Eric Lai, Intel coreboot Reviewers, Jakub Czapiga, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Matt DeVillier, Nick Vaccaro, Pranava Y N, Sean Rhodes, Tarun, Werner Zeh, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/86164?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins)
Change subject: soc/intel: Allow zero values for PMC GPE0 DW registers ......................................................................
soc/intel: Allow zero values for PMC GPE0 DW registers
The `pmc_gpe0_different_values` function previously asserted if any two of the GPE0 DW registers (DW0, DW1, DW2) had the same value, as introduced in commit hash 640a41f3ee938b794b14 (soc/intel: Assert if `pmc_/gpe0_dwX` values are not unique). This prevented platforms from disabling GPE routing via PMC by setting all DW values to zero.
This commit modifies the check to allow all DW registers to be zero. This enables platforms that don't require PMC-controlled GPE routing to boot without triggering the assertion. A warning message is printed if all DW values are zero, indicating that dwX value is set to 0.
The change was verified by testing the following scenarios:
- **All DWs zero:** A warning message is printed, and the system boots using the default GPE route. No assertion occurs. - **Duplicate DWs (e.g., DW0=1, DW1=2, DW2=2):** The existing assertion is triggered as expected. - **Unique DWs (e.g., DW0=1, DW1=2, DW2=3):** No errors occur.
TEST=Built and booted normally. No assertion failure observed.
Change-Id: Ie66d6dbcf49d5400b3fc3e4da113a569fe52dd51 Signed-off-by: Subrata Banik subratabanik@google.com --- M src/soc/intel/alderlake/pmutil.c M src/soc/intel/apollolake/pmutil.c M src/soc/intel/cannonlake/pmutil.c M src/soc/intel/elkhartlake/pmutil.c M src/soc/intel/jasperlake/pmutil.c M src/soc/intel/meteorlake/pmutil.c M src/soc/intel/pantherlake/pmutil.c M src/soc/intel/skylake/pmutil.c M src/soc/intel/tigerlake/pmutil.c 9 files changed, 90 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/86164/4