John Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39438 )
Change subject: soc/intel/tigerlake: Configure Vmx support using Kconfig ......................................................................
soc/intel/tigerlake: Configure Vmx support using Kconfig
Change VmxEnable UPD value based on Kconfig ENABLE_VMX
BUG=None TEST=Built image and booted to kernel.
Change-Id: I725474643193223865a135813cf882fd7636d24a Signed-off-by: John Zhao john.zhao@intel.com --- M src/soc/intel/tigerlake/romstage/fsp_params_tgl.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/39438/1
diff --git a/src/soc/intel/tigerlake/romstage/fsp_params_tgl.c b/src/soc/intel/tigerlake/romstage/fsp_params_tgl.c index f0f3b4c..8b81616 100644 --- a/src/soc/intel/tigerlake/romstage/fsp_params_tgl.c +++ b/src/soc/intel/tigerlake/romstage/fsp_params_tgl.c @@ -124,6 +124,9 @@ m_cfg->PchHdaIDispLinkTmode = config->PchHdaIDispLinkTmode; m_cfg->PchHdaIDispLinkFrequency = config->PchHdaIDispLinkFrequency; m_cfg->PchHdaIDispCodecDisconnect = config->PchHdaIDispCodecDisconnect; + + /* Change VmxEnable UPD value according to ENABLE_VMX Kconfig */ + m_cfg->VmxEnable = CONFIG(ENABLE_VMX); }
void platform_fsp_memory_init_params_cb(FSPM_UPD *mupd, uint32_t version)
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39438 )
Change subject: soc/intel/tigerlake: Configure Vmx support using Kconfig ......................................................................
Patch Set 1: Code-Review+1
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39438 )
Change subject: soc/intel/tigerlake: Configure Vmx support using Kconfig ......................................................................
Patch Set 1: Code-Review+1
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39438 )
Change subject: soc/intel/tigerlake: Configure Vmx support using Kconfig ......................................................................
Patch Set 1: Code-Review+2
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39438 )
Change subject: soc/intel/tigerlake: Configure Vmx support using Kconfig ......................................................................
Patch Set 1: Code-Review+2
Hello Wonkyu Kim, Wonkyu Kim, Frans Hendriks, Caveh Jalali, Nick Vaccaro, Patrick Rudolph, Venkata Krishna Nimmagadda,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39438
to look at the new patch set (#2).
Change subject: soc/intel/tigerlake: Configure Vmx support using Kconfig ......................................................................
soc/intel/tigerlake: Configure Vmx support using Kconfig
Change VmxEnable UPD value based on Kconfig ENABLE_VMX
BUG=None TEST=Built image and booted to kernel.
Change-Id: I725474643193223865a135813cf882fd7636d24a Signed-off-by: John Zhao john.zhao@intel.com --- M src/soc/intel/tigerlake/romstage/fsp_params_tgl.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/39438/2
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39438 )
Change subject: soc/intel/tigerlake: Configure Vmx support using Kconfig ......................................................................
Patch Set 2: Code-Review+1
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39438 )
Change subject: soc/intel/tigerlake: Configure Vmx support using Kconfig ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39438 )
Change subject: soc/intel/tigerlake: Configure Vmx support using Kconfig ......................................................................
soc/intel/tigerlake: Configure Vmx support using Kconfig
Change VmxEnable UPD value based on Kconfig ENABLE_VMX
BUG=None TEST=Built image and booted to kernel.
Change-Id: I725474643193223865a135813cf882fd7636d24a Signed-off-by: John Zhao john.zhao@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39438 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Caveh Jalali caveh@chromium.org Reviewed-by: Wonkyu Kim wonkyu.kim@intel.com --- M src/soc/intel/tigerlake/romstage/fsp_params_tgl.c 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Caveh Jalali: Looks good to me, but someone else must approve Wonkyu Kim: Looks good to me, approved
diff --git a/src/soc/intel/tigerlake/romstage/fsp_params_tgl.c b/src/soc/intel/tigerlake/romstage/fsp_params_tgl.c index 072c99e..3872b61 100644 --- a/src/soc/intel/tigerlake/romstage/fsp_params_tgl.c +++ b/src/soc/intel/tigerlake/romstage/fsp_params_tgl.c @@ -145,6 +145,9 @@ m_cfg->VtdBaseAddress[4] = TBT1_BASE_ADDRESS; m_cfg->VtdBaseAddress[5] = TBT2_BASE_ADDRESS; m_cfg->VtdBaseAddress[6] = TBT3_BASE_ADDRESS; + + /* Change VmxEnable UPD value according to ENABLE_VMX Kconfig */ + m_cfg->VmxEnable = CONFIG(ENABLE_VMX); }
void platform_fsp_memory_init_params_cb(FSPM_UPD *mupd, uint32_t version)