Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68217 )
Change subject: nb/intel/i945/raminit: Use 'bool' for do_reset ......................................................................
nb/intel/i945/raminit: Use 'bool' for do_reset
Signed-off-by: Elyes Haouas ehaouas@noos.fr Change-Id: I692b86bba28853186185846f63dad1dcbfce1eea --- M src/northbridge/intel/i945/raminit.c 1 file changed, 15 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/68217/1
diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c index 58e5032..93b0a83 100644 --- a/src/northbridge/intel/i945/raminit.c +++ b/src/northbridge/intel/i945/raminit.c @@ -215,7 +215,7 @@ static void sdram_detect_errors(struct sys_info *sysinfo) { u8 reg8; - u8 do_reset = 0; + bool do_reset = false;
reg8 = pci_read_config8(PCI_DEV(0, 0x1f, 0), GEN_PMCON_2);
@@ -224,7 +224,7 @@ printk(BIOS_DEBUG, "SLP S4# Assertion Width Violation.\n"); /* Write back clears bit 2 */ pci_write_config8(PCI_DEV(0, 0x1f, 0), GEN_PMCON_2, reg8); - do_reset = 1; + do_reset = true;
}
@@ -232,7 +232,7 @@ printk(BIOS_DEBUG, "DRAM initialization was interrupted.\n"); reg8 &= ~(1 << 7); pci_write_config8(PCI_DEV(0, 0x1f, 0), GEN_PMCON_2, reg8); - do_reset = 1; + do_reset = true; }
/* Set SLP_S3# Assertion Stretch Enable */ @@ -257,12 +257,12 @@ if (((sysinfo->dimm[0] != SYSINFO_DIMM_NOT_POPULATED) || (sysinfo->dimm[1] != SYSINFO_DIMM_NOT_POPULATED)) && !(mchbar_read8(SLFRCS) & (1 << 0))) { - do_reset = 1; + do_reset = true; } if (((sysinfo->dimm[2] != SYSINFO_DIMM_NOT_POPULATED) || (sysinfo->dimm[3] != SYSINFO_DIMM_NOT_POPULATED)) && !(mchbar_read8(SLFRCS) & (1 << 1))) { - do_reset = 1; + do_reset = true; } }